Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Update Apollon to version 3.0.0 #57

Merged
merged 11 commits into from
Oct 27, 2023

Conversation

matthiaslehnertum
Copy link
Collaborator

@matthiaslehnertum matthiaslehnertum commented Oct 12, 2023

This PR increases the included Apollon version to 3.0.0

@matthiaslehnertum matthiaslehnertum changed the title Update Apollon to version 1.5.2 Development: Update Apollon to version 1.5.2 Oct 12, 2023
packages/shared/package.json Outdated Show resolved Hide resolved
@matthiaslehnertum matthiaslehnertum changed the title Development: Update Apollon to version 1.5.2 Development: Update Apollon to version 3.0.0-beta.1 Oct 16, 2023
@krusche
Copy link
Member

krusche commented Oct 19, 2023

Can we merge this PR and deploy 2.0.0.beta.1 on the Apollon Test Server ?

@matthiaslehnertum
Copy link
Collaborator Author

@krusche Can be merged from my perspective, Alexander requested additional information in regards to the canvas module and the additionally required libraries in the README but I can update that in another PR.

@loreanvictor
Copy link
Contributor

there are two versioning issues currently:

  • Error: shared@npm:1.7.3: No candidates found. I think shared package refers to the workspace package and should also be updated then.

  • When running build:webapp:local, there are typing mismatches between react@18.2.0 and @types/react@18.0.27, resulting in the following error happening all across the code base:

    Type 'Element' is not assignable to type 'ReactNode'.
    

    I've found a similar issue here, with the recommended fix of updating to @types/react@^18.2.25 resolving the issue, locally at least.

I'll push a commit to fix these issues.

@matthiaslehnertum matthiaslehnertum changed the title Development: Update Apollon to version 3.0.0-beta.1 Development: Update Apollon to version 3.0.0 Oct 25, 2023
Copy link
Contributor

@loreanvictor loreanvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked it out and everything seems fine (it was also checked before and the new versions are in sync). fixed a little mistake on the readme, it should be good to go.

@matthiaslehnertum matthiaslehnertum merged commit ca94f34 into main Oct 27, 2023
1 check passed
@matthiaslehnertum matthiaslehnertum deleted the feature/update-apollon-version branch October 27, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants