-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add embed option to share modal #92
Conversation
Hmm, basically everyone uses GitHub using dark mode, we should add a background 🤔 Also maybe you can switch around the buttons: This might be better what do you think? |
Why are the recently shared diagrams separate? Do you copy each part? I thought we add an additional "Recently shared embed" if it exists and have one button that copies the markdown text for the whole embed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested and it works, I see the screen shot of the diagram in the github issue after pasting it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked as expected when testing on the consolidated branch, code looks also good to me
This PR adds the embed option to the share modal.
Upon clicking on embed, a text of two lines is copied to the clipboard. If the text is pasted in a pull request / issue, an image of the diagram together with a link to editing a copy can be seen.
This is a screenshot of an example embedding in #98 coming from a test server of Apollon:
In the future, when version management of diagrams is implemented, as described in #97, the embedding will display the newest version of a diagram.