-
Notifications
You must be signed in to change notification settings - Fork 301
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Development: Restrict course detail page access (#9834)
- Loading branch information
Showing
4 changed files
with
305 additions
and
83 deletions.
There are no files selected for viewing
65 changes: 0 additions & 65 deletions
65
src/main/webapp/app/overview/course-dashboard/course-dashboard-guard.service.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| import { Injectable, inject } from '@angular/core'; | ||
| import { ActivatedRouteSnapshot, CanActivate, Router } from '@angular/router'; | ||
| import { Observable, of, switchMap } from 'rxjs'; | ||
| import { CourseStorageService } from 'app/course/manage/course-storage.service'; | ||
| import { CourseManagementService } from 'app/course/manage/course-management.service'; | ||
| import { Course, isCommunicationEnabled } from 'app/entities/course.model'; | ||
| import dayjs from 'dayjs/esm'; | ||
| import { ArtemisServerDateService } from 'app/shared/server-date.service'; | ||
| import { CourseOverviewRoutePath } from 'app/overview/courses-routing.module'; | ||
|
|
||
| @Injectable({ | ||
| providedIn: 'root', | ||
| }) | ||
| export class CourseOverviewGuard implements CanActivate { | ||
| private courseStorageService = inject(CourseStorageService); | ||
| private courseManagementService = inject(CourseManagementService); | ||
| private router = inject(Router); | ||
| private serverDateService = inject(ArtemisServerDateService); | ||
|
|
||
| /** | ||
| * Check if the client can activate a course overview route. | ||
| * @return true if the client is allowed to access the route, false otherwise | ||
| */ | ||
| canActivate(route: ActivatedRouteSnapshot): Observable<boolean> { | ||
| const courseIdString = route.parent?.paramMap.get('courseId'); | ||
| if (!courseIdString) { | ||
| return of(false); | ||
| } | ||
| const courseIdNumber = parseInt(courseIdString, 10); | ||
|
|
||
| const path = route.routeConfig?.path; | ||
| if (!path) { | ||
| return of(false); | ||
| } | ||
| //we need to load the course from the server to check if the user has access to the requested route. The course in the cache might not be sufficient (e.g. misses exams or lectures) | ||
| return this.courseManagementService.findOneForDashboard(courseIdNumber).pipe( | ||
| switchMap((res) => { | ||
| if (res.body) { | ||
| // Store course in cache | ||
| this.courseStorageService.updateCourse(res.body); | ||
| } | ||
| // Flatten the result to return Observable<boolean> directly | ||
| return this.handleReturn(this.courseStorageService.getCourse(courseIdNumber), path); | ||
| }), | ||
| ); | ||
| } | ||
|
|
||
| handleReturn = (course?: Course, type?: string): Observable<boolean> => { | ||
| let hasAccess: boolean; | ||
| switch (type) { | ||
| // Should always be accessible | ||
| case CourseOverviewRoutePath.EXERCISES: | ||
| hasAccess = true; | ||
| break; | ||
| case CourseOverviewRoutePath.LECTURES: | ||
| hasAccess = !!course?.lectures; | ||
| break; | ||
| case CourseOverviewRoutePath.EXAMS: | ||
| hasAccess = this.hasVisibleExams(course); | ||
| break; | ||
| case CourseOverviewRoutePath.COMPETENCIES: | ||
| hasAccess = !!(course?.numberOfCompetencies || course?.numberOfPrerequisites); | ||
| break; | ||
| case CourseOverviewRoutePath.TUTORIAL_GROUPS: | ||
| hasAccess = !!course?.numberOfTutorialGroups; | ||
| break; | ||
| case CourseOverviewRoutePath.DASHBOARD: | ||
| hasAccess = course?.studentCourseAnalyticsDashboardEnabled ?? false; | ||
| break; | ||
| case CourseOverviewRoutePath.FAQ: | ||
| hasAccess = course?.faqEnabled ?? false; | ||
| break; | ||
| case CourseOverviewRoutePath.LEARNING_PATH: | ||
| hasAccess = course?.learningPathsEnabled ?? false; | ||
| break; | ||
| case CourseOverviewRoutePath.COMMUNICATION: | ||
| hasAccess = isCommunicationEnabled(course); | ||
| break; | ||
| default: | ||
| hasAccess = false; | ||
| } | ||
| if (!hasAccess) { | ||
| // Default route, redirect to exercises if the user does not have access to the requested route | ||
| this.router.navigate([`/courses/${course?.id}/exercises`]); | ||
| } | ||
| return of(hasAccess); | ||
| }; | ||
|
|
||
| hasVisibleExams(course?: Course): boolean { | ||
| if (course?.exams) { | ||
| for (const exam of course.exams) { | ||
| if (exam.visibleDate && dayjs(exam.visibleDate).isBefore(this.serverDateService.now())) { | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.