You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since some time, the tests for the LinkPreviewIntegrationTest fail constantly on GitHub, I fixed them temporarily in #8037 so that all our tests get executed, but this class needs refactoring.
Currently, the test will actually call foreign domains which are not under our control, the PR #8037 changes that, but in my understanding, this should be mocked to work without an internet connection to qualify as an integration test.
To Reproduce
Run the server tests.
Expected behavior
Actual integration tests with mocks are written. The tests must pass without an internet connection and not DOS another domain.
Screenshots
No response
Which version of Artemis are you seeing the problem on?
on develop
What browsers are you seeing the problem on?
Other (specify in "Additional context")
Additional context
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered:
Describe the bug
Since some time, the tests for the LinkPreviewIntegrationTest fail constantly on GitHub, I fixed them temporarily in #8037 so that all our tests get executed, but this class needs refactoring.
Currently, the test will actually call foreign domains which are not under our control, the PR #8037 changes that, but in my understanding, this should be mocked to work without an internet connection to qualify as an integration test.
To Reproduce
Run the server tests.
Expected behavior
Actual integration tests with mocks are written. The tests must pass without an internet connection and not DOS another domain.
Screenshots
No response
Which version of Artemis are you seeing the problem on?
on develop
What browsers are you seeing the problem on?
Other (specify in "Additional context")
Additional context
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: