Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Refactor LinkPreviewIntegrationTest #8054

Closed
reschandreas opened this issue Feb 19, 2024 · 0 comments · Fixed by #8449
Closed

Development: Refactor LinkPreviewIntegrationTest #8054

reschandreas opened this issue Feb 19, 2024 · 0 comments · Fixed by #8449

Comments

@reschandreas
Copy link
Contributor

reschandreas commented Feb 19, 2024

Describe the bug

Since some time, the tests for the LinkPreviewIntegrationTest fail constantly on GitHub, I fixed them temporarily in #8037 so that all our tests get executed, but this class needs refactoring.

Currently, the test will actually call foreign domains which are not under our control, the PR #8037 changes that, but in my understanding, this should be mocked to work without an internet connection to qualify as an integration test.

To Reproduce

Run the server tests.

Expected behavior

Actual integration tests with mocks are written. The tests must pass without an internet connection and not DOS another domain.

Screenshots

No response

Which version of Artemis are you seeing the problem on?

on develop

What browsers are you seeing the problem on?

Other (specify in "Additional context")

Additional context

No response

Relevant log output

No response

@sarpsahinalp sarpsahinalp self-assigned this Apr 19, 2024
@sarpsahinalp sarpsahinalp linked a pull request Apr 20, 2024 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants