Development: Fix some failing Postgres tests and LinkPreviewIntegrationTest

[reschandreas]

Checklist

General

• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
• I strictly followed the server coding and design guidelines.

Motivation and Context

This PR fixes some postgres tests because an invalid SQL construct was used. It also fixes the now constantly failing LinkPreviewIntegrationTest which should be completely refactored, I'll open an issue -> #8054

The postgres tests still don't pass completely, one to two tests are very flacky and I can't reproduce that on my machine.

Description

Steps for Testing

Check if the SQL has changed, because it should not

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Code Review

• Code Review 1
• Code Review 2

Test Coverage

Screenshots

Summary by CodeRabbit

Summary by CodeRabbit

• Refactor
  • Improved query efficiency and accuracy in the results repository.
• Tests
  • Updated integration tests to reflect changes in referenced URLs, enhancing test reliability.
• Chores
  • Updated import statements and domain class list in the ResultRepository.

[coderabbitai]

Walkthrough

This update involves refining the ResultRepository and LinkPreviewIntegrationTest within a Java project. Changes include enhancing SQL queries for better data grouping, adjusting domain class imports, and revising integration tests to use internal URLs instead of external ones, ensuring tests are less dependent on external services. This aims to improve the reliability and maintainability of both data handling and testing frameworks.

Changes

File Path	Change Summary
src/main/java/de/tum/in/www1/artemis/repository/ResultRepository.java	Importing specific classes, modifying group-by clauses in queries, and updating imported domain classes.
src/test/java/de/tum/in/www1/artemis/metis/linkpreview/LinkPreviewIntegrationTest.java	Updated URLs in tests to point to different locations, including GitHub pull requests and maintaining references to https://github.com and https://google.com.

Related issues

• Development: Refactor LinkPreviewIntegrationTest #8054: The changes in LinkPreviewIntegrationTest align with the objectives by refactoring tests to avoid calling foreign domains, potentially implementing mocks, enhancing test reliability, and adhering to best practices.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[MichaelOwenDyer]

Thank you for fixing this!

[rstief]

this still calls a foreign url

[reschandreas]

all of them do, I tried it with artemis URLs but then the test failed, I hope someone fixes this when someone takes on #8054 as I don't want to loose much time right now

[rstief]

You are right, my bad 💀

[laurenzfb]

✅ ✅ ✅

[milljoniaer]

Thanks for fixing this 🍏

[rstief]

You are right, my bad 💀