Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication: Add feature availability list to user documentation #10015

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

julian-wls
Copy link
Contributor

@julian-wls julian-wls commented Dec 13, 2024

Checklist

General

Motivation and Context

As discussed in the last communication meeting the a list of available features should be made publically available to make it easier for users to compare available features for each platform.

Description

This PR adds a table to the communication documentation (docs/user/communication.rst) and introduces labels that are placed next to each feature to show what the status of feature is on the web app, iOS app and Android app.
Status labels are AVAILABLE, UNAVAILABLE, WIP, PLANNED and NOT PLANNED.

Steps for Testing

Prerequisites:
1 Student

Navigate to the communication documentation and verify that there is a new section called Communication Features Availability with a table that explains each status and another table containing a row for each feature.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Introduced a "Communication Features Availability" section detailing feature status across platforms.
    • Added subsections for user, moderator, and instructor features with specific functionalities.
    • Included a "Status explained" subsection for clarity on feature availability.
    • Enhanced document with visual elements, including instructional videos.
    • Updated mobile applications documentation to include a reference link for available communication features on iOS and Android platforms.

@julian-wls julian-wls self-assigned this Dec 13, 2024
@julian-wls julian-wls requested a review from a team as a code owner December 13, 2024 14:22
@julian-wls julian-wls added small communication Pull requests that affect the corresponding module labels Dec 13, 2024
Copy link

coderabbitai bot commented Dec 13, 2024

Walkthrough

The pull request introduces significant updates to the communication.rst document, including a new section titled "Communication Features Availability," which outlines the status of various communication features across platforms (Web App, iOS, Android). This section features a comprehensive table categorizing each feature's availability status and includes a "Status explained" subsection. Additional sections detailing features for users, moderators, and instructors have been added, specifying functionalities and restrictions. Existing content has been retained and enhanced with new visual elements, improving the document's clarity and usability.

Changes

File Change Summary
docs/user/communication.rst - Added "Communication Features Availability" section
- Added "Status explained" subsection
- Added table of features availability
- Added "Features for Users" section
- Added "Features for Moderators" section
- Added "Features for Instructors" section
- Retained and supplemented existing sections with new features and statuses
- Included HTML raw embeds for videos demonstrating functionalities
docs/user/mobile-applications.rst - Modified overview section to include a reference link for available communication features on iOS and Android platforms

Possibly related PRs

Suggested labels

component:Communication

Suggested reviewers

  • anian03
  • dmytropolityka
  • marlon-luca-bu
  • SimonEntholzer

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. This feature will be included in our Pro Plan when released.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
docs/user/communication.rst (1)

330-334: Improve organization of platform-specific notes.

The notes section mixes implementation details with user-facing information.

Consider:

  1. Moving implementation details to developer documentation.
  2. Organizing platform-specific notes in a more structured format:
Platform-Specific Features
-------------------------

Web App
^^^^^^^
- Leave chat available for groups only
- Image download through browser

iOS
^^^^
- Leave chat for groups and non course-wide channels
- Group chat creation via 'Create Chat'

Android
^^^^^^^
- Leave chat for channels, groups, and DMs
- Group chat creation via 'Create Chat'
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fafe68c and 2d47477.

📒 Files selected for processing (1)
  • docs/user/communication.rst (1 hunks)
🔇 Additional comments (1)
docs/user/communication.rst (1)

155-319: Enhance feature table clarity and tracking.

The feature availability table could benefit from the following improvements:

  1. Consider adding version numbers or target release dates for features marked as WIP or PLANNED.
  2. Structure the "Actor Restrictions" column consistently using bullet points:
-| Pin Messages                                         | Groups: group creators             |
+| Pin Messages                                         | • Groups: group creators           |

docs/user/communication.rst Show resolved Hide resolved
coderabbitai[bot]
coderabbitai bot previously approved these changes Dec 13, 2024
FelberMartin
FelberMartin previously approved these changes Dec 13, 2024
Copy link
Contributor

@FelberMartin FelberMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

It would be good to also mention this section in the Mobile Applications page. I think a short info like "For the most up-to-date feature availability status, check [link]" would be enough :D

PaRangger
PaRangger previously approved these changes Dec 13, 2024
Copy link
Contributor

@PaRangger PaRangger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing, great job 🥳

Copy link

⚠️ Unable to deploy to test servers ⚠️

The docker build needs to run through before deploying.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Dec 13, 2024
@HawKhiem HawKhiem added deploy:artemis-test3 and removed deployment-error Added by deployment workflows if an error occured labels Dec 13, 2024
Copy link

⚠️ Unable to deploy to test servers ⚠️

The docker build needs to run through before deploying.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Dec 13, 2024
asliayk
asliayk previously approved these changes Dec 13, 2024
Copy link
Contributor

@asliayk asliayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

Copy link
Member

@anian03 anian03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! I just noticed one inconsistency with the confluence page: On iOS, link formatting is already available (that's also what it says on Confluence) – however here it is listed as planned.

Copy link
Contributor

@cremertim cremertim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, i would like to hear your opinion on it

docs/user/communication.rst Outdated Show resolved Hide resolved
docs/user/communication.rst Outdated Show resolved Hide resolved
docs/user/communication.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the communication Pull requests that affect the corresponding module label Dec 14, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
docs/user/communication.rst (1)

332-336: Consider adding visual separation for implementation notes

While the notes provide valuable clarification, consider adding a visual separator (like a horizontal rule) before the note section to improve readability.

+----
+
.. note:: 
    - Leave chat option is available on the web app for groups only, on iOS for groups and non course-wide channels, and on Android for channels, groups, and DMs.
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2d47477 and ff9a5d2.

📒 Files selected for processing (2)
  • docs/user/communication.rst (1 hunks)
  • docs/user/mobile-applications.rst (1 hunks)
🔇 Additional comments (3)
docs/user/mobile-applications.rst (1)

13-13: LGTM: Well-integrated cross-reference

The added cross-reference to the communication features list enhances documentation connectivity and helps users find relevant information.

docs/user/communication.rst (2)

109-127: Consider improving status badges implementation

The current implementation using raw HTML with inline styles could be improved for better maintainability and accessibility.


157-321: LGTM: Well-structured feature availability documentation

The table effectively documents feature availability across platforms with:

  • Clear categorization of features
  • Explicit actor restrictions
  • Consistent status indicators
  • Platform-specific implementation status

Copy link

⚠️ Unable to deploy to test servers ⚠️

The docker build needs to run through before deploying.

Copy link
Contributor

@asliayk asliayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapprove

@HawKhiem HawKhiem added deploy:artemis-test2 and removed deployment-error Added by deployment workflows if an error occured labels Dec 14, 2024
Copy link

⚠️ Unable to deploy to test servers ⚠️

The docker build needs to run through before deploying.

@github-actions github-actions bot added the deployment-error Added by deployment workflows if an error occured label Dec 14, 2024
Copy link

@eylulnc eylulnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great👌🏻

Copy link
Contributor

@FelberMartin FelberMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve

Copy link
Contributor

@PaRangger PaRangger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove

Copy link
Contributor

@cremertim cremertim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks for applying my changes!

@julian-wls julian-wls requested a review from a team as a code owner December 17, 2024 08:31
@julian-wls julian-wls added ready to merge and removed deployment-error Added by deployment workflows if an error occured ready for review labels Dec 17, 2024
@krusche krusche added this to the 7.8.0 milestone Dec 20, 2024
@krusche krusche merged commit 0ebce2e into develop Dec 20, 2024
9 of 10 checks passed
@krusche krusche deleted the chore/general/update-communication-documentation branch December 20, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged
Status: Done
Development

Successfully merging this pull request may close these issues.

10 participants