Programming exercises: Fix padding issue in task display

[PaRangger]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• I strictly followed the client coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

Currently, when editing a programming exercise using the online editor, the task display looks buggy (the border touches the icons, and the background color is different):

Additionally, the task display for not executed tests looks different to the one for tests that have no result. These should look the same (the circle is black and is bigger than it should be, look at "Screenshots" for how it is supposed to look like).

Description

I removed the border and changed the background color of the task display so that it blends in better with the rest of the components.

Steps for Testing

Prerequisites:

• This needs to be tested on a Server with the code lifecycle enabled (e.g. TS2 or TS3)
• 1 Instructor
• 1 Programming Exercise (on TS3 you can go to Paul Ranggers Test Course, there is one set up)

1. Log in to Artemis
2. Go to Course Management
3. Go to course
4. Go to Exercises
5. Go to the programming exercise
6. Click "Edit in editor"
7. On the right side, click "Preview" in the "Problem Statement" section
8. Verify that the task display looks properly spaced now
9. You can switch between "Solution", "Template" and "Assignment" next to the title on the top left to see other cases (Success & Failure)

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Manual Tests

• Test 1
• Test 2

Screenshots

Summary by CodeRabbit

• Style
  • Updated styling for programming exercise instruction headers
  • Modified button state styling in step wizard component

[coderabbitai]

Walkthrough

The pull request involves modifications to two SCSS files related to programming exercise instructions. The changes primarily affect the styling of headers and buttons in the instruction step wizard. In the programming-exercise-editable-instruction.scss file, the background color and border properties of the .card-second-header class have been updated. In the programming-exercise-instruction-step-wizard.scss file, a new class selector for button styling has been added to handle the "not executed" state.

Changes

File	Change Summary
src/main/webapp/app/exercises/programming/manage/instructions-editor/programming-exercise-editable-instruction.scss	Modified .card-second-header class background color and removed border-bottom
src/main/webapp/app/exercises/programming/shared/instructions-render/step-wizard/programming-exercise-instruction-step-wizard.scss	Added & &--not-executed.btn to existing button styling selector

Possibly related PRs

• Exam mode: Fix displaying incorrect task in exam summary exercise #9294: Changes to CSS classes in programming exercise instruction component
• Programming exercises: Fix table overflow in rendered markdown #9957: Styling updates for markdown table rendering
• Programming exercises: Improve task bar design #10095: Task bar design updates with HTML and CSS modifications

Suggested labels

bugfix, tests

Suggested reviewers

• Feras797
• DominikRemo
• coolchock
• krusche
• sawys777

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/main/webapp/app/exercises/programming/shared/instructions-render/step-wizard/programming-exercise-instruction-step-wizard.scss (1)

82-83: LGTM! Good use of SCSS nesting and consistent naming.

The changes effectively address the UI consistency issue by properly grouping similar states together. The use of SCSS nesting and consistent naming conventions makes the code maintainable.

Consider extracting common values into variables.

For better maintainability, consider extracting the font size 0.4rem into a variable, similar to how $step-font-size is used.

 $step-font-size: 0.6rem;
+$step-icon-size: 0.4rem;
 $step-button-size: 21px;
 
 // ... later in the file
     & &--no-result.btn,
     .btn.not-done,
     & &--not-executed.btn {
         color: $gray-600;
-        font-size: 0.4rem;
+        font-size: $step-icon-size;
     }

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e0cda16 and 404a43f.

📒 Files selected for processing (2)

• src/main/webapp/app/exercises/programming/manage/instructions-editor/programming-exercise-editable-instruction.scss (1 hunks)
• src/main/webapp/app/exercises/programming/shared/instructions-render/step-wizard/programming-exercise-instruction-step-wizard.scss (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• src/main/webapp/app/exercises/programming/manage/instructions-editor/programming-exercise-editable-instruction.scss

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Codacy Static Code Analysis

[Feras797]

Tested on TS3, the preview is now properly spaced.

[ItsaaaMeMario]

Tested on TS3, works as expected.

[vinceclifford]

Tested on TS3, works as expected.

[coolchock]

code

[HawKhiem]

Tested on TS3. Works as described