-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Improve build plan relationship
#6099
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise, we get NotYetImplementedException: Collections having FK in secondary table
src/main/java/de/tum/in/www1/artemis/repository/BuildPlanRepository.java
Outdated
Show resolved
Hide resolved
Development
: Improve build plan relationship
…b.com/ls1intum/Artemis into chore/improve-build-plan-relationship
jpbernius
previously approved these changes
Jan 18, 2023
jpbernius
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally and after the fix with the missing FETCH
I can confirm that GitLab can build the pipelines based on the build plan fetched from the API.
src/main/java/de/tum/in/www1/artemis/repository/BuildPlanRepository.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR affects setups with Gitlab CI (which is still experimental)
Checklist
General
Server
Motivation and Context
At the moment, the relationship between
ProgrammingExercise
->BuildPlan
is not ideal, because it leads to additional database queries / joins in many situation due to the nature of aManyToOne
relationship.As the build plan is only needed in 2-3 situations, it is favorable to store the unidirectional relationship on the other side:
BuildPlan
->ProgrammingExercise
as aOneToMany
relationshipDescription
Steps for Testing
Prerequisites:
Exam Mode Testing
Test that the Gitlab CI features are still working
Review Progress
Code Review
Manual Tests