Programming exercises: Delete directory for import from file if error occurs

[tobias-lippert]

Checklist

General

• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Server

• Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
• I followed the coding and design guidelines.
• I added multiple integration tests (Spring) related to the features (with a high test coverage).
• I documented the Java code using JavaDoc style.

Changes affecting Programming Exercises

• I tested all changes and their related features with all corresponding user types on Test Server 1 (Atlassian Suite).
• I tested all changes and their related features with all corresponding user types on Test Server 2 (Jenkins and Gitlab).

Motivation and Context

Currently, when importing a programming exercise from file, the directory is only scheduled for the deletion if the import is successful.
We, however, want to delete it regardless if the import fails or not.

Description

Wrap the import process in a try block and the directory deletion scheduling in a finally block, so it's always executed.
Since this is hard to test on a test server without access to the file system, I added server tests, to ensure the deletion method is invoked.

Steps for Testing

Code review only.

Review Progress

Performance Review

• I confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Test Coverage

Server

Class/File	Line Coverage	Confirmation (assert/expect)
ProgrammingExerciseImportFromFileService.java	95%	✅

[JohannesStoehr]

Code should fix the issue. Insurgent simply putting the deletion right after getting the folder instead of putting it into a finally block

[terlan98]

Code LGTM. There's a star import that you could replace, but it's non-blocking.

[JohannesStoehr]

Only changed imports. Still look good to me