-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated code lifecycle
: Separate build agent summary and details view
#8395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
server
Pull requests that update Java code. (Added Automatically!)
client
Pull requests that update TypeScript code. (Added Automatically!)
labels
Apr 13, 2024
…iew' into feature/localci/decouple-agent-view
mateusmm01
temporarily deployed
to
artemis-test3.artemis.cit.tum.de
April 14, 2024 09:01 — with
GitHub Actions
Inactive
mateusmm01
temporarily deployed
to
artemis-test6.artemis.cit.tum.de
April 14, 2024 09:16 — with
GitHub Actions
Inactive
mateusmm01
added
deploy:artemis-test6
and removed
lock:artemis-test3
lock:artemis-test6
labels
Apr 14, 2024
mateusmm01
temporarily deployed
to
artemis-test6.artemis.cit.tum.de
April 14, 2024 12:13 — with
GitHub Actions
Inactive
mateusmm01
temporarily deployed
to
artemis-test6.artemis.cit.tum.de
April 14, 2024 13:09 — with
GitHub Actions
Inactive
JohannesWt
approved these changes
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove 👍
krusche
changed the title
May 11, 2024
Integrated code lifecycle
: Decouple build agent summary and details viewIntegrated code lifecycle
: Separate build agent summary and details view
florian-glombik
temporarily deployed
to
artemis-test3.artemis.cit.tum.de
May 11, 2024 21:07 — with
GitHub Actions
Inactive
florian-glombik
approved these changes
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed the testing steps and it worked fine, I do have some suggestions for a follow up regarding the UI:
- Even if I am in full screen the
Running build jobs
table will need to be scrolled horizontally, I think it would be good if the table would not need to be scrolled
- I guess that it would be beneficial if there would be a general navigation option to the Build Agents (I did not find that option, except for clicking on a build agent if one is running)
- I think that the
Cancel All
button should not be displayed or disabled if there are no build jobs running
5 tasks
27 tasks
This was referenced Nov 17, 2024
This was referenced Nov 25, 2024
This was referenced Dec 3, 2024
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
client
Pull requests that update TypeScript code. (Added Automatically!)
component:integrated code lifecycle
server
Pull requests that update Java code. (Added Automatically!)
tests
too-long-open
!!! This is an antipattern, we should aim for small PRs that are only open for a short time !!!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
Client
authorities
to all new routes and checked the course groups for displaying navigation elements (links, buttons).Changes affecting Programming Exercises
Motivation and Context
The current BuildAgentView is very cluttered and hardy navigable with lots of build agents and recent build jobs. This view should be decoupled to a BuildAgentSummaryView and BuildAgentDetailsView
Description
BuildAgentSummaryView: Offers a list of all build agents and their running build jobs.
BuildAgentDetailsView: Shows the running build jobs for a specific agent and it's recent build jobs.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Client
Server
Screenshots
Build Agent Summary
Build Agent Details
Build Queue with clickable agent name
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Style
Tests