Skip to content

Exam mode: Change test case default visibility to after results release date #8451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 98 commits into from
May 18, 2024
Merged
Changes from 1 commit
Commits
Show all changes
98 commits
Select commit Hold shift + click to select a range
1df3004
Fix logging in setup script
florian-glombik Dec 4, 2023
09c1c0a
Adjust the default visibility for exam exercises to after due date by…
florian-glombik Dec 6, 2023
c4911ca
Adding TODO for reset functionality
florian-glombik Dec 6, 2023
eae0daa
Adjusting logic for reset exercise
florian-glombik Dec 6, 2023
c53dc54
Fixing warning
florian-glombik Dec 6, 2023
2ebce5f
Reduce code duplication and improve code quality
florian-glombik Dec 6, 2023
6eb9e95
Fixing test case
florian-glombik Dec 6, 2023
c1d8a8d
Fixing bugs from #7738
florian-glombik Dec 7, 2023
c819440
Displaying different name for option depending on exam or normal mode
florian-glombik Dec 7, 2023
7e1f32d
Adjusting the translations
florian-glombik Dec 7, 2023
33cfe04
Improve Javadoc readability
florian-glombik Dec 7, 2023
eb325ab
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik Dec 7, 2023
e149ae9
Adding tests for utils function
florian-glombik Dec 7, 2023
4022735
Removing unused import
florian-glombik Dec 7, 2023
e44527d
Adding test for resetting the exercise
florian-glombik Dec 7, 2023
0d4f09e
Adding tests for the initial generation
florian-glombik Dec 7, 2023
fccf70a
Reducing code duplication
florian-glombik Dec 7, 2023
a013a4b
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik Dec 7, 2023
131e7f6
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik Dec 9, 2023
5cf0a35
Fix mistake in documentation
florian-glombik Dec 9, 2023
e15df52
Fixing cypress tests
florian-glombik Dec 9, 2023
384d382
Cleanup code and add javadoc
florian-glombik Dec 10, 2023
ed85943
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik Dec 10, 2023
9355cdc
Increase timeout, as test must now wait until re-configuration is pos…
florian-glombik Dec 11, 2023
d73a74f
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik Dec 11, 2023
43abeef
Fixing E2E tests by increasing timeouts
florian-glombik Dec 11, 2023
e3ac5a4
Fixing client code style tests
florian-glombik Dec 11, 2023
d094fb0
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik Dec 11, 2023
32700c2
Fixing client style
florian-glombik Dec 12, 2023
037d424
Merge remote-tracking branch 'origin/enhancement/exam/change-test-cas…
florian-glombik Dec 12, 2023
ba16995
Try to fix cypress tests failing due to "Cypress detected that you re…
florian-glombik Dec 12, 2023
ff98087
Try to fix cypress tests
florian-glombik Dec 13, 2023
e6ecd14
Merge branch 'refs/heads/develop' into enhancement/exam/change-test-c…
florian-glombik Apr 20, 2024
ad4fd19
Fixing visibility import
florian-glombik Apr 20, 2024
c38077c
Fixing renaming mistake from merge
florian-glombik Apr 20, 2024
06b6aa4
Fixing test
florian-glombik Apr 20, 2024
8146e34
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik Apr 21, 2024
eea4149
Reverting change that led to failing exercise group creation
florian-glombik Apr 21, 2024
6c5a27d
Fixing cypress tests
florian-glombik Apr 21, 2024
f2d233b
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik Apr 24, 2024
58dd132
Fixing playwright tests
florian-glombik Apr 24, 2024
68ce9f2
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik Apr 26, 2024
afe001a
Reducing Maximum Timeout amount
florian-glombik Apr 26, 2024
345b260
Update src/main/webapp/i18n/de/programmingExercise.json
florian-glombik May 1, 2024
099ede6
Merge remote-tracking branch 'origin/enhancement/exam/change-test-cas…
florian-glombik May 2, 2024
1faed70
Addressing feedback from Johannes, passing programming exercise inste…
florian-glombik May 2, 2024
a008292
Merge branch 'refs/heads/develop' into enhancement/exam/change-test-c…
florian-glombik May 8, 2024
fbe5708
Simplifying help translation
florian-glombik May 8, 2024
4e8774b
Adding toggle to setReleaseDateOfResults to after due date on exercis…
florian-glombik May 8, 2024
d67c583
Adding toggle to setReleaseDateOfResults to after due date on exercis…
florian-glombik May 8, 2024
7d5425f
artemisTranslate vs jhiTranslate
florian-glombik May 8, 2024
793b087
Only display toggle for exam imports
florian-glombik May 8, 2024
03b21fb
Simplify translation
florian-glombik May 8, 2024
c45e07f
Add todo
florian-glombik May 8, 2024
98ff6c1
Only display the option to set the test cases to after release date o…
florian-glombik May 8, 2024
bbca50e
Pass import options down to lifecycle component
florian-glombik May 8, 2024
c2750ad
Moving javadoc and make sure to pass the flag to the server when impo…
florian-glombik May 8, 2024
35d1f84
Adding todo
florian-glombik May 8, 2024
200996d
Processing setTestCaseVisibilityToAfterReleaseDateOfResults
florian-glombik May 8, 2024
7f0f984
Set test case visibility to after due date if the parameter is passed
florian-glombik May 8, 2024
656a0de
Fixing javadoc
florian-glombik May 8, 2024
f24bac3
User vs var
florian-glombik May 8, 2024
babdb3c
Renaming variable for setTestCaseVisibilityToAfterDueDate
florian-glombik May 8, 2024
0e1ce48
Update exercise creation screenshot in documentation
florian-glombik May 8, 2024
67c31e7
Updating documentation
florian-glombik May 8, 2024
db9bf28
Fixing cypress E2E test by increasing max timeout duration
florian-glombik May 10, 2024
e97bbd0
Hiding option for import from files
florian-glombik May 10, 2024
189ada7
Trying to fix client tests remote by reverting change of passing down…
florian-glombik May 10, 2024
8e3b81a
Address codeRabbit comment, simplify updateIsImportBasedOnUrl
florian-glombik May 10, 2024
9f20751
Trying to fix memory leak that only seems to occur on remote for clie…
florian-glombik May 10, 2024
3197792
Fixing client tests
florian-glombik May 10, 2024
f32f3ef
Moving type export to programming exercise model.ts
florian-glombik May 10, 2024
626ccd8
Fixing import path of ImportOptions
florian-glombik May 10, 2024
bb83c64
Moving ImportOptions interface to own file to resolve conflicts
florian-glombik May 10, 2024
3febacf
Increase timeout to reduce flakyness
florian-glombik May 10, 2024
d981897
Merge branch 'refs/heads/develop' into enhancement/exam/change-test-c…
florian-glombik May 10, 2024
0bd6d4b
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik May 10, 2024
a858094
Removing outdated comment
florian-glombik May 10, 2024
ad253b9
Remove outdated todo
florian-glombik May 10, 2024
d4c189f
Revert translation change
florian-glombik May 10, 2024
365bb78
Make test cases mutable
florian-glombik May 10, 2024
eddc6a1
Removing TODO
florian-glombik May 10, 2024
85b4b03
Merge remote-tracking branch 'origin/enhancement/exam/change-test-cas…
florian-glombik May 10, 2024
8f9507b
Adding import for HashSet
florian-glombik May 10, 2024
a8a1470
jhi-translate vs jhiTranslate
florian-glombik May 10, 2024
c9a8aff
Adding setTestCaseVisibilityToAfterDueDate to ProgrammingExerciseCrea…
florian-glombik May 10, 2024
247a85b
Re adding Translate Pipe Mock
florian-glombik May 10, 2024
a2c16af
Using jhiTranslate instead of pipe
florian-glombik May 10, 2024
e865c86
Removing mock of pipe
florian-glombik May 10, 2024
b12c5b1
Trying to fix client tests failing remotely: removing setVisibility f…
florian-glombik May 10, 2024
bdaa9c2
Merge branch 'refs/heads/develop' into enhancement/exam/change-test-c…
florian-glombik May 11, 2024
c0ea276
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik May 12, 2024
97a1be3
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik May 14, 2024
833bfee
Addressing Ramonas review
florian-glombik May 15, 2024
0e218ff
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik May 16, 2024
47bffa2
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik May 16, 2024
b594f34
Merge branch 'develop' into enhancement/exam/change-test-case-default…
florian-glombik May 17, 2024
8a56815
Merge branch 'refs/heads/develop' into enhancement/exam/change-test-c…
florian-glombik May 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
jhi-translate vs jhiTranslate
  • Loading branch information
florian-glombik committed May 10, 2024

Verified

This commit was signed with the committer’s verified signature.
rbeuque74 Romain Beuque
commit a8a14701e49faa81de78deb36b7246e076e27048
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@
}
<div class="test-schedule-date px-1">
<div class="test-schedule-date-title test-schedule-date-title-small-button">
<span jhi-translate="artemisApp.programmingExercise.timeline.automaticTests"></span>
<span jhiTranslate="artemisApp.programmingExercise.timeline.automaticTests"></span>
<jhi-help-icon text="artemisApp.programmingExercise.timeline.automaticTestsMandatoryTooltip" />
</div>
<div class="btn btn-light scheduled-test btn-lifecycle" [class.btn-lifecycle--disabled]="readOnly">
@@ -62,7 +62,7 @@
<div>
<div class="test-schedule-date px-1">
<div class="test-schedule-date-title test-schedule-date-title-small-button">
<span jhi-translate="artemisApp.programmingExercise.timeline.assessmentType"></span>
<span jhiTranslate="artemisApp.programmingExercise.timeline.assessmentType"></span>
<jhi-help-icon
[text]="
'artemisApp.programmingExercise.timeline.' +
@@ -117,7 +117,7 @@
</div>
</div>
@if (!readOnly) {
<h6 jhi-translate="artemisApp.assessment.assessment"></h6>
<h6 jhiTranslate="artemisApp.assessment.assessment"></h6>
@if (isExamMode || exercise.course?.complaintsEnabled) {
<div class="form-check">
<input
@@ -133,7 +133,7 @@ <h6 jhi-translate="artemisApp.assessment.assessment"></h6>
[ngStyle]="exercise.assessmentType !== assessmentType.AUTOMATIC || (!isExamMode && !exercise.dueDate) ? { color: 'grey' } : {}"
class="form-control-label"
for="allowComplaintsForAutomaticAssessment"
jhi-translate="artemisApp.programmingExercise.timeline.complaintOnAutomaticAssessment"
jhiTranslate="artemisApp.programmingExercise.timeline.complaintOnAutomaticAssessment"
></label>
<jhi-help-icon placement="right auto" [text]="'artemisApp.programmingExercise.timeline.complaintOnAutomaticAssessmentTooltip'" />
</div>
@@ -169,7 +169,7 @@ <h6 jhi-translate="artemisApp.assessment.assessment"></h6>
[ngStyle]="exercise.assessmentType !== assessmentType.SEMI_AUTOMATIC ? { color: 'grey' } : {}"
class="form-control-label"
for="allowManualFeedbackRequests"
jhi-translate="artemisApp.programmingExercise.timeline.manualFeedbackRequests"
jhiTranslate="artemisApp.programmingExercise.timeline.manualFeedbackRequests"
></label>
<jhi-help-icon placement="right auto" [text]="'artemisApp.programmingExercise.timeline.manualFeedbackRequestsTooltip'" />
</div>
@@ -184,7 +184,7 @@ <h6 jhi-translate="artemisApp.assessment.assessment"></h6>
[(ngModel)]="exercise.showTestNamesToStudents"
checked
/>
<label class="form-control-label" for="field_showTestNamesToStudents" jhi-translate="artemisApp.programmingExercise.showTestNamesToStudents"></label>
<label class="form-control-label" for="field_showTestNamesToStudents" jhiTranslate="artemisApp.programmingExercise.showTestNamesToStudents"></label>
<jhi-help-icon placement="right auto" [text]="'artemisApp.programmingExercise.showTestNamesToStudentsTooltip'" />
</div>
<div class="form-check">
@@ -201,7 +201,7 @@ <h6 jhi-translate="artemisApp.assessment.assessment"></h6>
[ngStyle]="!exercise.exampleSolutionPublicationDate && !exercise.exerciseGroup?.exam?.exampleSolutionPublicationDate ? { color: 'grey' } : {}"
class="form-control-label"
for="releaseTestsWithExampleSolution"
jhi-translate="artemisApp.programmingExercise.timeline.releaseTestsWithExampleSolution"
jhiTranslate="artemisApp.programmingExercise.timeline.releaseTestsWithExampleSolution"
></label>
<jhi-help-icon placement="right auto" [text]="'artemisApp.programmingExercise.timeline.releaseTestsWithExampleSolutionTooltip'" />
</div>