Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix quiz exercise drop location e2e test #8581

Merged
merged 1 commit into from
May 15, 2024

Conversation

muradium
Copy link
Contributor

@muradium muradium commented May 13, 2024

Checklist

General

Client

Motivation and Context

E2E test about drop locations in a drag and drop quiz exercise fails.

Description

Changes quiz exercise interactive mode activation action in POM for E2E test.

Steps for Testing

  • Code Review: Ensure that tests pass for valid reasons, functionality is adequately tested and check the code quality.
  • Run the tests (optional): Tests are checked by automatic run in CI environment. You can optionally run them locally and check if they pass.

Steps for running the tests:

  1. Navigate to src/tests/playwright
  2. Configure Playwright using playwright.env file based on your local setup. Current configuration should work for default Artemis setup.
  3. Run npm install && npm run playwright:setup && npx playwright test e2e/exercise/quiz-exercise/QuizExerciseDropLocation.spec.ts
  4. Confirm that "Checks drop locations" test passes

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Summary by CodeRabbit

  • New Features

    • Introduced a new functionality for checking exam results, including detailed assessments and feedback across various exercise types.
    • Added methods to fetch grade summaries and handle text exercise submissions with flexibility in request types.
  • Enhancements

    • Enhanced various methods to improve element location techniques and parameter flexibility, enhancing the interaction with exercise and exam components.
  • Documentation

    • Updated documentation to reflect new features and enhancements in exam and exercise management.
  • Refactor

    • Modified several methods to use more efficient element locating strategies and added optional parameters to existing methods for better customization.

@muradium muradium requested a review from a team as a code owner May 13, 2024 07:29
Copy link

coderabbitai bot commented May 13, 2024

Walkthrough

The update involves a modification in the DragAndDropQuiz class within the Playwright test suite. The method activateInteractiveMode has been adjusted to interact with a dropdown list, selecting the 'Exporting' option, instead of the previous behavior of clicking a button. This change streamlines the interaction process within the quiz functionality of the test suite.

Changes

File Path Change Summary
.../pageobjects/exercises/quiz/DragAndDropQuiz.ts Updated activateInteractiveMode to select from dropdown instead of clicking a button.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between fd6768b and 03ff65c.
Files selected for processing (1)
  • src/test/playwright/support/pageobjects/exercises/quiz/DragAndDropQuiz.ts (1 hunks)
Additional comments not posted (1)
src/test/playwright/support/pageobjects/exercises/quiz/DragAndDropQuiz.ts (1)

60-61: Change in interaction method from button click to dropdown selection appears correct.

Verification successful

Change in interaction method from button click to dropdown selection is supported throughout the test suite as no references to the old method were found.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that the new dropdown interaction is supported throughout the test suite.

# Test: Search for any references to the old button click method in the test suite. Expect: No occurrences.
rg --type typescript $'modeling-editor-sidebar.*button'

Length of output: 91



Script:

#!/bin/bash
# Description: Verify that the new dropdown interaction is supported throughout the test suite by checking for any references to the old button click method.

# Test: Search for any references to the old button click method in the test suite. Expect: No occurrences.
rg --type ts $'modeling-editor-sidebar.*button'

Length of output: 48


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@JohannesWt JohannesWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

Copy link
Contributor

@az108 az108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@krusche krusche changed the title General: Fix quiz exercise drop location e2e test Development: Fix quiz exercise drop location e2e test May 15, 2024
@krusche krusche added this to the 7.1.0 milestone May 15, 2024
@krusche krusche merged commit c8a128e into develop May 15, 2024
51 of 53 checks passed
@krusche krusche deleted the bugfix/playwright/fix-quiz-drop-locations branch May 15, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants