-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Make exercise view scrollable
#8688
General
: Make exercise view scrollable
#8688
Conversation
WalkthroughThe changes primarily address the issue of problem statements not being displayed on mobile devices. By adding a Changes
Sequence Diagram(s) (Beta)Not applicable for these changes. Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if many people will use Artemis like this but if so - they can scroll now :) tested on TS3 - works as described
7fb2071
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected on ts3
Screen.Recording.2024-06-08.at.20.39.07.movThis weeks FPV homework had the same problem that it was not properly displayed. This is the case on a notebook now as well. so it does not online concern mobile devices with a small width, but is a general problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
@bassner or any maintainer. can you review this PR so it can be merged? |
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
General
: Make Exercise View ScrollableGeneral
: Make exercise view scrollable
Checklist
General
Client
Motivation and Context
Fixes #8674
The Course Overview page can't be properly displayed on some mobile devices with narrow screens (even with the sidebar collapsed). This PR implements a quick fix to make the view scrollable for those screens
Description
Added CSS to make it scrollable
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Test Coverage
Screenshots
2024-05-28_16-34-49.mp4