Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Make exercise view scrollable #8688

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

zhngharry
Copy link
Contributor

@zhngharry zhngharry commented May 28, 2024

Checklist

General

Client

Motivation and Context

Fixes #8674

The Course Overview page can't be properly displayed on some mobile devices with narrow screens (even with the sidebar collapsed). This PR implements a quick fix to make the view scrollable for those screens

Description

Added CSS to make it scrollable

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Student
  • 1 Programming Exercise
  1. Log in to Artemis
  2. Navigate to Course Overview
  3. Take a look at Exercise Page with a narrow screen
  4. Verify that everything is able to be displayed now

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked






Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Screenshots

2024-05-28_16-34-49.mp4

@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label May 28, 2024
@zhngharry zhngharry temporarily deployed to artemis-test6.artemis.cit.tum.de May 28, 2024 14:49 — with GitHub Actions Inactive
@zhngharry zhngharry marked this pull request as ready for review May 28, 2024 14:55
@zhngharry zhngharry requested a review from a team as a code owner May 28, 2024 14:55
Copy link

coderabbitai bot commented May 28, 2024

Walkthrough

The changes primarily address the issue of problem statements not being displayed on mobile devices. By adding a horizontal-scroll class to a specific <div> in the course-exercises.component.html and including a media query in course-overview.scss, horizontal scrolling is enabled on smaller screens, ensuring that users can view the problem statements by scrolling horizontally.

Changes

File Path Change Summary
src/main/webapp/app/overview/course-exercises/course-exercises.component.html Added horizontal-scroll class to a <div> to enable horizontal scrolling.
src/main/webapp/app/overview/course-overview.scss Added a media query for screens with a max-width of 500px to apply overflow-x: auto to .horizontal-scroll.

Sequence Diagram(s) (Beta)

Not applicable for these changes.

Assessment against linked issues

Objective Addressed Explanation
Fix Problem Statements not getting displayed on mobile Phones (#8674)
Ensure the website is scrollable to the side in mobile view and desktop view on the phone (#8674)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot previously approved these changes May 28, 2024
JohannesWt
JohannesWt previously approved these changes May 29, 2024
Copy link
Contributor

@JohannesWt JohannesWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if many people will use Artemis like this but if so - they can scroll now :) tested on TS3 - works as described

@zhngharry zhngharry dismissed stale reviews from JohannesWt and coderabbitai[bot] via 7fb2071 May 31, 2024 21:27
Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@az108 az108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@egekurt123 egekurt123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected on ts3

@janthoXO
Copy link
Contributor

janthoXO commented Jun 8, 2024

Screen.Recording.2024-06-08.at.20.39.07.mov

This weeks FPV homework had the same problem that it was not properly displayed. This is the case on a notebook now as well. so it does not online concern mobile devices with a small width, but is a general problem

Copy link
Contributor

@edkaya edkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@janthoXO
Copy link
Contributor

@bassner or any maintainer. can you review this PR so it can be merged?

@github-actions github-actions bot removed the stale label Jun 17, 2024
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 24, 2024
@bassner bassner added this to the 7.3.1 milestone Jun 26, 2024
@bassner bassner merged commit 1edba55 into develop Jun 26, 2024
26 of 36 checks passed
@bassner bassner deleted the bugfix/general/make-course-overview-responsive branch June 26, 2024 09:38
@krusche krusche changed the title General: Make Exercise View Scrollable General: Make exercise view scrollable Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) stale
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Fix Problem Statements not getting displayed on mobile Phones