Adaptive learning: Fix an issue that standardized competencies could not be deleted when they had a linked competency

[rstief]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

Standardized Competencies could not be deleted if they had a linked competecy.

Description

Sets the foreign key constraint for linked competencies to onDelete="SET NULL". This allows the standardized competency to be deleted.

Steps for Testing

1. Test on ts3 or somewhere you are admin.
2. Go to course management -> competencies -> import competencies -> import standardized competencies
3. Import any standardized competency into your course
4. Go to Server Administration -> Standardized Competencies
5. Delete the standardized competency you imported
6. see that it works :)

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

unchanged

[coderabbitai]

Walkthrough

The changes made to the StandardizedCompetencyIntegrationTest.java file include the addition of necessary imports for Competency and CompetencyRepository, and the introduction of a new test method shouldDeleteCompetencyWithLinkedCompetency. This new test method ensures that deleting a competency with a linked standardized competency is properly handled.

Changes

File Path	Change Summary
src/test/java/de/tum/in/www1/artemis/competency/StandardizedCompetencyIntegrationTest.java	Added imports for Competency and CompetencyRepository, introduced competencyRepository field, and added shouldDeleteCompetencyWithLinkedCompetency test method.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant Test as StandardizedCompetencyIntegrationTest
    participant Repo as CompetencyRepository
    participant Service as CompetencyService
    participant DB as Database

    Test->>Repo: Find competency by ID
    Repo-->>Test: Return competency
    Test->>Service: Request deletion of competency
    Service->>DB: Delete competency and linked standardized competency
    DB-->>Service: Confirmation of deletion
    Service-->>Test: Deletion successful

Loading

This diagram illustrates the flow of the new shouldDeleteCompetencyWithLinkedCompetency test method, highlighting the interactions between the test, repository, service, and database components.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[JohannesWt]

Demonstrated in testing session - Code also LGTM

[Jan-Thurner]

demonstrated in a testing session. Works as expected. Code also looks good.

[az108]

Tested in Testing Session and works as expected 👍

[JohannesStoehr]

Migration looks good to me

[MaximilianAnzinger]

Maintainer approved