Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Use @Override annotation consistently #8818

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

Strohgelaender
Copy link
Contributor

@Strohgelaender Strohgelaender commented Jun 18, 2024

Checklist

General

Motivation and Context

The @Override annotation can act as a safeguard to also change overwriting places if the signature of one method changes.
It should therefore always be present if applicable.

Description

Added the annotation via automated inspection. I also removed some unused code that I came across during that.

Steps for Testing

code review

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Summary by CodeRabbit

  • Refactor
    • Enhanced method clarity and reliability by adding @Override annotations to various methods across multiple classes.
  • Tests
    • Improved test consistency by adding @Override annotations to setup methods in various integration test classes.

@Strohgelaender Strohgelaender requested a review from a team as a code owner June 18, 2024 17:24
@github-actions github-actions bot added tests server Pull requests that update Java code. (Added Automatically!) labels Jun 18, 2024

This comment was marked as spam.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Copy link
Contributor

@edkaya edkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm

Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

Copy link
Contributor

@marlon-luca-bu marlon-luca-bu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

@Strohgelaender Strohgelaender added this to the 7.2.3 milestone Jun 19, 2024
@krusche krusche merged commit 6fc9a05 into develop Jun 21, 2024
36 of 38 checks passed
@krusche krusche deleted the chore/style/override branch June 21, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge server Pull requests that update Java code. (Added Automatically!) small tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants