-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Use @Override annotation consistently
#8818
Conversation
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
src/main/java/de/tum/in/www1/artemis/service/connectors/localci/LocalCIService.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
Checklist
General
Motivation and Context
The
@Override
annotation can act as a safeguard to also change overwriting places if the signature of one method changes.It should therefore always be present if applicable.
Description
Added the annotation via automated inspection. I also removed some unused code that I came across during that.
Steps for Testing
code review
Review Progress
Code Review
Summary by CodeRabbit
@Override
annotations to various methods across multiple classes.@Override
annotations to setup methods in various integration test classes.