-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Restructure server code completely into modules
#9307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to de.tum.cit.aet.artemis
WORK IN PROGRESS
WORK IN PROGRESS
WORK IN PROGRESS
WORK IN PROGRESS
server currently starts
WORK IN PROGRESS
krusche
added
server
Pull requests that update Java code. (Added Automatically!)
chore
priority:critical
refactoring
labels
Sep 11, 2024
krusche
changed the title
Sep 11, 2024
Development
: Restructure server codeDevelopment
: Restructure server code completely into modules
…m/Artemis into chore/restructure-server
ole-ve
previously approved these changes
Sep 12, 2024
MaximilianAnzinger
previously approved these changes
Sep 12, 2024
MaximilianAnzinger
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
client
Pull requests that update TypeScript code. (Added Automatically!)
config-change
Pull requests that change the config in a way that they require a deployment via Ansible.
documentation
priority:critical
refactoring
server
Pull requests that update Java code. (Added Automatically!)
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING
HUGE REFACTORING
This PR completely restructures the server code:
de.tum.in.www1.artemis
tode.tum.cit.aet.artemis
Artemis will initially contain the following modules (for now only folders)
Please notice, that this PR is a starting point. Not all files are perfectly sorted into their respective folder (module) yet, however as this is a breaking refactoring that will definitely lead to merge conflicts with all other open branches / PRs, we wanted to finish a good first version. We kindly ask all developers for understanding, this refactoring was necessary and will significantly simplify development in the future.
No actual code was changed, except to fix compile errors or testing issues (e.g. changed visibility, removal of unused code).
This PR will only be tested quickly because with so many changes, it does not make sense to conduct a code review nor can we keep it open for a long time. In case issues are found, please report them and we will fix them in smaller follow-up PRs. However, as we only moved files into different folders, nothing should be broken.
We apologize for inconveniences while resolving merge conflicts!
In a follow-up, we plan to move the server tests into the same folder structure in the test folder.
Checklist
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.