-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text exercises
: Highlight selected result in result history timeline
#9845
Merged
krusche
merged 18 commits into
develop
from
feature/text-exercises/highlight-selected-result
Jan 4, 2025
Merged
Text exercises
: Highlight selected result in result history timeline
#9845
krusche
merged 18 commits into
develop
from
feature/text-exercises/highlight-selected-result
Jan 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
General
: Hihglight selected result in result history timeline
General
: Hihglight selected result in result history timelineGeneral
: Highlight selected result in result history timeline
HawKhiem
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cathy0123456789
approved these changes
Dec 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS1. Works as expected, however I agree with @BBesrour's comment how it would be nice if the right side were clickable too
maximiliansoelch
approved these changes
Jan 2, 2025
This was referenced Jan 6, 2025
This was referenced Jan 21, 2025
Merged
13 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
client
Pull requests that update TypeScript code. (Added Automatically!)
maintainer-approved
The feature maintainer has approved the PR
ready to merge
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Server
No Server Changes
Client
Changes affecting Programming Exercises
No Changes
Motivation and Context
When using the result history timeline on the result view, it is unclear which submission has been selected by the student (apart from the id on the link).
Description
This PR addresses this issue by highlighting the chosen submission. The selected submission is passed on by the text editor component and is checked on the timeline componented whether the highlighted color for the icon is shown. (primary blue to not interfere with green/red/grey)
Also migrates text-editor.component.ts / text-editor.component.ts and result-history.component.ts / result-history.component.ts to using signals
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Screenshots
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Tests