feat: Setup deployment microservice #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbanu
changed the title
gbanu
changed the title
thielpa
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
proposal: Seems like there are different spacings used in this file. I would propose to use a linter e.g. checkstyle also for the server part (of course in a separate issue)
There was a problem hiding this comment.
discussion: can we share some of them in a global .gitignore in the server folder for all microservices? Not sure though, but I do not like the code duplication
| public record EnvironmentInfoDTO( | ||
| @NonNull Long id, | ||
| @NonNull String name, | ||
| @NonNull String description, |
There was a problem hiding this comment.
question: Shouldn't the description be nullable (or empty string)?
| @NonNull Status status, | ||
| @NonNull Long createdByUserId, | ||
| OffsetDateTime createdAt, | ||
| List<InstalledAppDTO> installedApps, |
There was a problem hiding this comment.
question: Should installedApps be nullable?
| environment.getInstalledApps() | ||
| .stream() | ||
| .map(InstalledAppDTO::toInstalledAppDTO) | ||
| .sorted() |
There was a problem hiding this comment.
question: Is this sorting by name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.