-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to poetry 2.0 #229 #238
base: develop
Are you sure you want to change the base?
Conversation
need to change workflow as well |
WalkthroughThis update changes the Poetry version used in two GitHub Actions workflows by updating it from 1.8.5 to 2.0.1. In addition, the README now includes an instruction for users with older Poetry versions to run Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🪛 YAMLlint (1.35.1).github/workflows/intelligence-service-qa.yml[warning] 27-27: wrong indentation: expected 12 but found 10 (indentation) ⏰ Context from checks skipped due to timeout of 90000ms (7)
🔇 Additional comments (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
server/intelligence-service/pyproject.toml (1)
12-24
: Dependency Specification Format ReviewThe dependencies are now declared as a list under the new
[dependencies]
section. Please verify that the version specifiers maintain a consistent format. For example, removing extra spaces around operators (e.g.,"fastapi[standard]==0.115.6"
instead of"fastapi[standard] == 0.115.6"
) and reviewing the use of parentheses in dependency strings (e.g.,"langgraph-checkpoint-postgres (>=2.0.8,<3.0.0)"
) so that they are parsed correctly by Poetry.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
server/intelligence-service/poetry.lock
is excluded by!**/*.lock
📒 Files selected for processing (4)
.github/workflows/generate-intelligence-service-client.yml
(1 hunks).github/workflows/intelligence-service-qa.yml
(1 hunks)server/intelligence-service/README.md
(1 hunks)server/intelligence-service/pyproject.toml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/intelligence-service-qa.yml
[warning] 27-27: wrong indentation: expected 12 but found 10
(indentation)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: Webhook Ingest / Build linux/arm64 Docker Image for ghcr.io/ls1intum/hephaestus/webhook-ingest
- GitHub Check: Webhook Ingest / Build linux/amd64 Docker Image for ghcr.io/ls1intum/hephaestus/webhook-ingest
- GitHub Check: Intelligence Service / Build linux/arm64 Docker Image for ghcr.io/ls1intum/hephaestus/intelligence-service
- GitHub Check: Webapp / Build linux/arm64 Docker Image for ghcr.io/ls1intum/hephaestus/webapp
- GitHub Check: Application Server / Build linux/arm64 Docker Image for ghcr.io/ls1intum/hephaestus/application-server
- GitHub Check: Intelligence Service / Build linux/amd64 Docker Image for ghcr.io/ls1intum/hephaestus/intelligence-service
- GitHub Check: Webapp / Build linux/amd64 Docker Image for ghcr.io/ls1intum/hephaestus/webapp
- GitHub Check: Application Server / Build linux/amd64 Docker Image for ghcr.io/ls1intum/hephaestus/application-server
🔇 Additional comments (5)
server/intelligence-service/README.md (1)
23-26
: Clear Poetry Update Instruction AddedThe new instruction clearly advises users with Poetry versions less than 2.0.0 to run
poetry self update
before installing dependencies. This is a helpful addition to ensure compatibility with the updated configuration. You might also consider adding a brief note about verifying the Poetry version afterward.server/intelligence-service/pyproject.toml (2)
1-10
: Adoption of New[project]
ConfigurationThe migration to a
[project]
section for metadata (including name, version, description, authors, readme, and requires-python) is well executed and aligns with modern standards. The structured authors list is clear and concise.
26-30
: Development Dependencies and Package Mode ConfigurationThe
[tool.poetry]
block now specifiespackage-mode = false
and includes a dedicated development dependency group with Black. This configuration appears correct and consistent with the updated project structure..github/workflows/intelligence-service-qa.yml (1)
25-32
: Poetry Version Update in WorkflowThe "Install Poetry" step has been updated to use version 2.0.1, which is consistent with the new project requirements. This change helps ensure that all workflow steps operate with the same Poetry version.
🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 27-27: wrong indentation: expected 12 but found 10
(indentation)
.github/workflows/generate-intelligence-service-client.yml (1)
43-51
: Consistent Poetry Version in Client Generation WorkflowThe "Install Poetry" step in this workflow now specifies version 2.0.1, matching the update made in the QA workflow. The configuration parameters (virtualenv creation, in-project setting, etc.) are correctly set, which should ensure consistency in dependency management across workflows.
@@ -24,7 +24,7 @@ jobs: | |||
- name: Install Poetry | |||
uses: snok/install-poetry@v1 | |||
with: | |||
version: 1.8.5 | |||
version: 2.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
YAML Indentation Issue
YAMLlint flagged an indentation problem on line 27 (expected 12 spaces but found 10). Please adjust the indentation for the version: 2.0.1
line to comply with YAML formatting standards.
🧰 Tools
🪛 YAMLlint (1.35.1)
[warning] 27-27: wrong indentation: expected 12 but found 10
(indentation)
Upgrade poetry to version 2.0
To test run
poetry self update
and then
poetry install
then test that the application still runs and performs as before.
Summary by CodeRabbit
Chores
Documentation
poetry self update
before proceeding.Refactor