Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build jar #4

Merged
merged 6 commits into from
Mar 8, 2023
Merged

Build jar #4

merged 6 commits into from
Mar 8, 2023

Conversation

bensofficial
Copy link
Member

Fixes #2

In this PR, we add the gradle task to build a jar. The build result will be added to a new release.
The jar is used in the Docker image. Therefore, it is sufficient to have only java installed.
TODO: When this PR is merged, it is necessary to adapt the command for using the plugin in Artemis (together when updating the version):

@bensofficial bensofficial added the enhancement New feature or request label Mar 8, 2023
@bensofficial bensofficial requested review from Mtze and jpbernius March 8, 2023 11:23
@bensofficial bensofficial self-assigned this Mar 8, 2023
@jpbernius jpbernius requested a review from b-fein March 8, 2023 11:48
Copy link
Contributor

@b-fein b-fein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JAR artifact built in the CI and when running it via the container both work (the JAR contains the necessary dependency classes and only fails in the sending step when setting some dummy ENV-vars).
The release artifact upload looks like the one for Artemis, so that should work, too.

So, only one small question about the local vs. CI build, looks good otherwise. 👍

Dockerfile Outdated Show resolved Hide resolved
RUN gradle clean classes
RUN gradle clean jar

FROM eclipse-temurin:8-jre
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question out of curiosity, fine as-is: Is there are reason why JDK 8 is used instead of, e.g. LTS17? As the JAR is only running inside a Docker container there should be no environment constraints.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For parsing the XML files we need some dependencies (JAXB). I remember that when I initialized this plugin it was complicated to find the right dependencies as they were handled by a corresponding Jenkins dependency.
Therefore, I just used this version to make it working, but it is planned to update the Java version.

Co-authored-by: Benedikt Fein <fein@fim.uni-passau.de>
@bensofficial bensofficial mentioned this pull request Mar 8, 2023
@jpbernius jpbernius merged commit 2734950 into main Mar 8, 2023
@jpbernius jpbernius deleted the build-jar branch March 8, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JAR executable
3 participants