Add application assessment #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and refactoring to the application assessment feature in the core client. The changes include adding new components, updating existing ones, and modifying the network layer to support new functionalities.
Enhancements to Application Assessment:
AssessmentCardcomponent to handle score and comment submissions for application assessments. (clients/core/src/ApplicationAdministration/ApplicationAssessment/components/AssessmentCard.tsx)ApplicationDetailsViewto include new methods for handling score, comment, and acceptance status changes, and integrated theAssessmentCardcomponent. (clients/core/src/ApplicationAdministration/ApplicationAssessment/ApplicationDetailsView.tsx) [1] [2] [3] [4]Network Layer Updates:
postApplicationAssessmentfunction to handle assessment submissions. (clients/core/src/network/mutations/postApplicationAssessment.ts)getApplicationParticipationsfunction to fetch application participations. (clients/core/src/network/queries/applicationParticipations.ts)Refactoring and Code Simplification:
course_phase_participationswithapplication_participationsin various components to align with new data structure. (clients/core/src/ApplicationAdministration/ApplicationAssessment/ApplicationsOverview.tsx,clients/core/src/ApplicationAdministration/ApplicationAssessment/components/MissingUniversityData.tsx) [1] [2] [3] [4] [5] [6]UI Enhancements:
Toastercomponent for displaying toast notifications. (clients/core/src/App.tsx,clients/shared_library/components/ui/toast.tsx) [1] [2] [3]These changes collectively improve the functionality and user experience of the application assessment feature, making it more robust and user-friendly.