Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom date formatting supports all cases #567

Merged
merged 6 commits into from
Oct 14, 2021
Merged

Custom date formatting supports all cases #567

merged 6 commits into from
Oct 14, 2021

Conversation

areq212
Copy link
Contributor

@areq212 areq212 commented Oct 14, 2021

Simple fix for issue #532. All cases specified in lise should work now.


TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry

@codecov-commenter
Copy link

Codecov Report

Merging #567 (a1a5977) into master (1e37051) will decrease coverage by 0.38%.
The diff coverage is 44.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   86.78%   86.40%   -0.39%     
==========================================
  Files          37       37              
  Lines        3815     3848      +33     
==========================================
+ Hits         3311     3325      +14     
- Misses        504      523      +19     
Impacted Files Coverage Δ
src/app.rs 68.65% <5.00%> (-27.18%) ⬇️
tests/integration.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e37051...a1a5977. Read the comment docs.

Copy link
Member

@meain meain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks for working on this. :)

@areq212
Copy link
Contributor Author

areq212 commented Oct 14, 2021

Cool thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants