Fix for utimensat01 test #67
Conversation
|
@shaikshavali1 can you do a peer review? I will review after you approve this PR. |
There was a problem hiding this comment.
@rsrinivas01, Could you please rename the original main function, invoke it from your new main with test parameters, instead of commenting out the original main.
rsrinivas01
force-pushed
the
utimensat01
branch
27 times, most recently
from
91aec6f to
2b38158
Compare
rsrinivas01
force-pushed
the
utimensat01
branch
6 times, most recently
from
995efb8 to
bce9dd1
Compare
rsrinivas01
force-pushed
the
utimensat01
branch
from
bce9dd1 to
86603e4
Compare
|
I think the code looks like it might be correct, but the complete lack of explanatory comments means that I can't review this. |
|
There's no comments here for why any of the changes were made. It looks to be extensive. At minimum, this needs a good amount of commenting for what is being tested and why. No one is likely to be able to come along and support this later (or now). |
|
@rsrinivas01 can you add comments to this PR explaining code addition and removals. Please add lots of comments. |
rsrinivas01
force-pushed
the
utimensat01
branch
from
86603e4 to
7133bc4
Compare
Added comments in the file explaining the changes. Please check. |
Comments added in the file explaining the changes. Please check and let me know. |
There was a problem hiding this comment.
@davidchisnall @SeanTAllen @hukoyu
Added comments in the file explaining the changes. Please check and let me know your views.
|
I've reviewed a couple times today. Both times I ended up confused by what is going on. I'll give it another try tomorrow. |
Modified the utimensat01.c file to check for different error and success conditions. Instead of using the utimensat_test.sh script the test will be run directly from the c file.