Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable table support for CommonMarker #1443

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

notEthan
Copy link
Contributor

Description

In switching from redcarpet to commonmarker, I found pipe-delimited tables did not render. commonmarker supports these and enabling them is a matter of merely adding :table to the extensions parameter of CommonMarker.render_html, and enabling existing tests for this markdown provider.

this was enabled by default for redcarpet long ago in #765 and I think it is good to do for commonmarker too.

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).
    (sort of, I just turned on existing tests)

@lsegal lsegal merged commit df03784 into lsegal:main Jun 12, 2022
@lsegal
Copy link
Owner

lsegal commented Jun 12, 2022

Thanks for this quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants