enable table support for CommonMarker #1443
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In switching from redcarpet to commonmarker, I found pipe-delimited tables did not render. commonmarker supports these and enabling them is a matter of merely adding
:table
to theextensions
parameter ofCommonMarker.render_html
, and enabling existing tests for this markdown provider.this was enabled by default for redcarpet long ago in #765 and I think it is good to do for commonmarker too.
Completed Tasks
bundle exec rake
locally (if code is attached to PR).(sort of, I just turned on existing tests)