Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XAG resubstitution for multiplicative complexity #231

Merged
merged 45 commits into from
Feb 11, 2020
Merged

Conversation

eletesta
Copy link
Contributor

@eletesta eletesta commented Dec 6, 2019

No description provided.

@eletesta eletesta requested review from msoeken and hriener December 6, 2019 10:14
Copy link
Member

@msoeken msoeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only minor comments.

include/mockturtle/algorithms/resubstitution.hpp Outdated Show resolved Hide resolved
include/mockturtle/algorithms/resubstitution.hpp Outdated Show resolved Hide resolved
@hriener
Copy link
Member

hriener commented Dec 10, 2019

The changes related to updating fanout may affect the quality and runtime of all resubstitution algorithms. It may make sense to rerun our resubstitution experiments before merging these changes.

@hriener
Copy link
Member

hriener commented Feb 7, 2020

Thanks. Seems to work now. We may want to merge this PR before PR #244. Is the PR ready?

@eletesta
Copy link
Contributor Author

eletesta commented Feb 11, 2020 via email

@hriener hriener merged commit a1f0f90 into master Feb 11, 2020
@hriener hriener deleted the bi_decomposition branch February 11, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants