Skip to content

Commit

Permalink
Makefile: build podman-remote-static with cgo disabled
Browse files Browse the repository at this point in the history
Resolves: containers#13557

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
  • Loading branch information
lsm5 committed Mar 21, 2022
1 parent e034db1 commit 8961dd3
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,10 @@ $(SRCBINDIR)/podman$(BINSFX): $(SRCBINDIR) .gopathok $(SOURCES) go.mod go.sum
-o $@ ./cmd/podman

$(SRCBINDIR)/podman-remote-static: $(SRCBINDIR) .gopathok $(SOURCES) go.mod go.sum
$(GOCMD) build \
CGO_ENABLED=0 \

This comment has been minimized.

Copy link
@mheon

mheon Mar 21, 2022

Can we do this for Linux only? Apparently OS X needs CGo to fix some sort of dns resolution issue

This comment has been minimized.

Copy link
@lsm5

lsm5 Mar 22, 2022

Author Owner

I see podman-remote-{linux,darwin,windows} targets in the Makefile already. So, do we need this podman-remote-static at all?

GOOS=$(GOOS) \
GOARCH=$(GOARCH) \
$(GO) build \
$(BUILDFLAGS) \
$(GO_LDFLAGS) '$(LDFLAGS_PODMAN_STATIC)' \
-tags "${REMOTETAGS}" \
Expand Down

0 comments on commit 8961dd3

Please sign in to comment.