DM-46363: Allow ObscoreExporter to work without SqlRegistry #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Sep 16, 2024
| for dataset_type_name in self.config.dataset_types: | ||
| _LOG.debug("Reading data for dataset %s", dataset_type_name) | ||
| refs = registry.queryDatasets(dataset_type_name, collections=collections, where=self.config.where) | ||
| refs = self.butler.registry.queryDatasets( |
There was a problem hiding this comment.
This is rewritten in #18 to use butler.query() but rebasing should be pretty straightforward.
dhirving
force-pushed
the
tickets/DM-46363
branch
from
8b5f367
to
7607dce
Compare
Remove a dependency on SqlRegistry in ObscoreExporter, to allow it to work with RemoteButler.
dhirving
force-pushed
the
tickets/DM-46363
branch
from
7607dce
to
62b100d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 62.07% 62.03% -0.04%
==========================================
Files 11 11
Lines 472 461 -11
Branches 108 107 -1
==========================================
- Hits 293 286 -7
+ Misses 169 166 -3
+ Partials 10 9 -1 ☔ View full report in Codecov by Sentry. |
andy-slac
approved these changes
Sep 17, 2024
|
Sure, go ahead and push it. |
|
OK, I updated mypy.ini, but I did not re-order things so |
dhirving
force-pushed
the
tickets/DM-46363
branch
from
1ada739
to
40f3db7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a dependency on SqlRegistry in ObscoreExporter, to allow it to work with RemoteButler for the SIAv2 project.