DM-41209: Make standalone, pip-installable lsst package #24
Conversation
taranu
force-pushed
the
tickets/DM-41209
branch
from
0a87950 to
c0e62c0
Compare
| authors = [ | ||
| {name="Rubin Observatory Data Management", email="dm-admin@lists.lsst.org"}, | ||
| ] | ||
| classifiers = [ |
There was a problem hiding this comment.
Add GPL license to the classifier list and maybe there is a Science/Research intended audience and topic Scientific/Engineering :: Astronomy (see astropy)?
pyproject.toml
Outdated
| "matplotlib", | ||
| "numpy", | ||
| "pydantic", | ||
| "pytest", |
There was a problem hiding this comment.
Test dependencies should not be in the core dependencies. You don't need to install pytest to use this package.
| requires-python = ">=3.10.0" | ||
| dependencies = [ | ||
| "astropy", | ||
| "gauss2d", |
There was a problem hiding this comment.
No. I suppose it could be as it's a single repo and meson is pip-installable, although I'm not sure if the build configuration meets PyPI's requirements. For now, I configured the non-eups build to pip-install the bindings, so that they show up in pip list and are recognized as dependencies.
python/lsst/__init__.py
Outdated
| @@ -0,0 +1,3 @@ | |||
| import pkgutil | |||
|
|
|||
| __path__ = pkgutil.extend_path(__path__, __name__) | |||
| @@ -59,7 +58,7 @@ class AsinhStretchSigned(apvis.BaseStretch): | |||
| to logarithmic behavior, expressed as a fraction of the | |||
| normalized image. Must be in the range between 0 and 1. | |||
| Default is 0.1 | |||
| """ | |||
| """ # noqa: W505 | |||
There was a problem hiding this comment.
Is this because of the math? Can you put a backslash in after the / to fix that? Does it render okay in sphinx?
There was a problem hiding this comment.
The math line is 10 characters too long, yes. Is a backslash supposed to split it? Anyway, most of this is copy-pasted from astropy and lightly modified. I haven't actually configured docs for the package yet so I'll do that on another ticket.
This functionality is in gauss2dfit now.
taranu
force-pushed
the
tickets/DM-41209
branch
from
c2586c0 to
595a24a
Compare
taranu
force-pushed
the
tickets/DM-41209
branch
from
595a24a to
78c8f8d
Compare
This drops the setup.py for a pyproject.toml and adds eups support, following DM-41309.
PyPI publication may happen someday but not soon, given that one of the dependencies is a C++ header-only library.