DM-42157: Improve model configuration and evaluation #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These could be separated but are all ultimately to support fitting Observations with different CoordinateSystems.
taranu
force-pushed
the
tickets/DM-42157
branch
2 times, most recently
from
5369a9c to
d4e85e9
Compare
fred3m
reviewed
Mar 11, 2024
| ), | ||
| rho=g2f.RhoParameterD(self.rho.value_initial, transform=transform_rho, fixed=self.rho.fixed), | ||
| ) | ||
| integralmodel: g2f.IntegralModel, |
There was a problem hiding this comment.
very picky detail here, but I think that the parameter should be renamed integral_model.
| ), | ||
| size_y=g2f.ReffYParameterD( | ||
| self.size_y.value_initial, transform=transform_size, fixed=self.size_y.fixed | ||
| ), | ||
| rho=g2f.RhoParameterD(self.rho.value_initial, transform=transform_rho, fixed=self.rho.fixed), | ||
| ) | ||
| sersicindex = g2f.SersicMixComponentIndexParameterD( |
tests/test_fit_bootstrap_model.py
Outdated
|
|
||
| @pytest.fixture(scope="module") | ||
| def configfitter_psfs(channels) -> dict[g2f.Channel, CatalogExposurePsfBootstrap]: | ||
| configdatas = {} |
tests/test_fit_bootstrap_model.py
Outdated
| for results in table_psf_fits.values(): | ||
| @pytest.fixture(scope="module") | ||
| def configdata_sources( | ||
| configfitter_psfs, tables_psf_fits, |
tests/test_fit_bootstrap_model.py
Outdated
| def configdata_sources( | ||
| configfitter_psfs, tables_psf_fits, | ||
| ) -> dict[g2f.Channel, CatalogExposureSourcesBootstrap]: | ||
| configdatas = {} |
tests/test_fit_bootstrap_model.py
Outdated
| ), | ||
| n_sources=n_sources, | ||
| ) | ||
| configdata = CatalogExposureSourcesBootstrap( |
tests/test_fit_bootstrap_model.py
Outdated
| return configdatas | ||
|
|
||
|
|
||
| def test_fit_psf(configfitter_psfs, tables_psf_fits): |
This happens if a band (observation) is dropped, e.g. due to no/bad data.
taranu
force-pushed
the
tickets/DM-42157
branch
from
d4e85e9 to
67b5df8
Compare
taranu
force-pushed
the
tickets/DM-42157
branch
from
67b5df8 to
c1bd744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes several important bug fixes as well as feature additions.