Configure to use unresolved refcats (see DM-49289) #286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsinfang
reviewed
Apr 9, 2025
| @@ -14,3 +14,4 @@ tasks: | |||
| config: | |||
| # Alert distribution only runnable in PP environment. | |||
| alertPackager.doProduceAlerts: True | |||
| config.astrometry.referenceSelector.doUnresolved: False | |||
There was a problem hiding this comment.
Is the leading config. necessary?
There was a problem hiding this comment.
Agree that the leading config. should not be there, but more importantly this is a config for calibrateImage not diaPipe. So to set this you would need to exclude calibrateImage from ApPipe.yaml above and redefine it here, along with all of it's custom connections and configs.
isullivan
requested changes
Apr 9, 2025
| @@ -14,3 +14,4 @@ tasks: | |||
| config: | |||
| # Alert distribution only runnable in PP environment. | |||
| alertPackager.doProduceAlerts: True | |||
| config.astrometry.referenceSelector.doUnresolved: False | |||
There was a problem hiding this comment.
Agree that the leading config. should not be there, but more importantly this is a config for calibrateImage not diaPipe. So to set this you would need to exclude calibrateImage from ApPipe.yaml above and redefine it here, along with all of it's custom connections and configs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.