DM-51139: Support separate read and write butlers in Prompt Processing #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, read_central_butler and write_central_butler are the same object, but splitting the references makes the usage patterns much clearer.
This allows pipeline inputs and outputs to go to different repos, spreading out server load.
All Butler operations run on explicit collections because they need *different* collections, so the requirement makes no sense.
The repos are CENTRAL_REPO and READ_CENTRAL_REPO, and the latter is optional.
hsinfang
approved these changes
Jun 24, 2025
| @@ -111,10 +111,7 @@ def get_central_butler(central_repo: str, instrument_class: str): | |||
| """ | |||
| # TODO: how much overhead do we take on from asking the central repo about | |||
| # the instrument instead of handling it internally? | |||
There was a problem hiding this comment.
The two lines of comments above can be removed too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the repo configuration to use a two-tier system, with an optional read-only repo to reduce load on the write repo. It also removes the old "calib repo" terminology.