Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(node/auxtel-ill-control.cp) add el9 network config & tests #1521

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

(node/auxtel-ill-control.cp) add el9 network config & tests #1521

wants to merge 1 commit into from
+115 −0

Conversation

dtapiacl
Copy link
Contributor

@dtapiacl dtapiacl commented Nov 4, 2024

Redeploy auxtel-ill-control.cp.lsst.org as EL9 from EL7.

@dtapiacl dtapiacl added the enhancement New feature or request label Nov 4, 2024
@dtapiacl dtapiacl self-assigned this Nov 4, 2024
jhoblitt
jhoblitt approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. It is conventional to have a after the # starting a comment but it isn't a blocker.

hieradata/node/auxtel-ill-control.cp.lsst.org.yaml Outdated Show resolved Hide resolved
@dtapiacl dtapiacl force-pushed the IT-5753_auxtel_ill_control_cp branch from 0b2a767 to eae0605 Compare November 4, 2024 19:11
gseriche
gseriche approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@gseriche gseriche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dtapiacl dtapiacl force-pushed the IT-5753_auxtel_ill_control_cp branch 7 times, most recently from 2000ddc to 3ea5e22 Compare November 13, 2024 00:44
@dtapiacl dtapiacl force-pushed the IT-5753_auxtel_ill_control_cp branch from 3ea5e22 to 54fdf34 Compare November 13, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gseriche gseriche gseriche approved these changes

@jhoblitt jhoblitt jhoblitt approved these changes

@cbarria cbarria Awaiting requested review from cbarria

@csilva-cl csilva-cl Awaiting requested review from csilva-cl

Assignees

@dtapiacl dtapiacl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtapiacl @jhoblitt @gseriche