(WIP) simplify module #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoblitt
force-pushed
the
feature/el8-el9
branch
18 times, most recently
from
94d07e7
to
8ec66d1
Compare
Because: a) these are server only packages b) on EL8 they are not available until after idm:DL1 is enabled.
The function of these parameters is confusing. That may be both set to true yet only client or server packages will be installed. The functionality of not installing packages could be handled by a param that allows overriding the package names (by setting it to an empty list).
and rm usage of `ipa_force_join` fact.
and enable logoutput => on_failure as ths use of env vars will prevent secrets from leaking into the console output (and also keep secrets from leaking via the process table).
This should be managed with a forge module. E.g. theforeman/dns
This should be managed with a forge module. E.g. puppetlabs/apache
+ rename to easy_ipa::helpers::flushcache and mark as @api_private.
Resolves this warning:
Warning: This function is deprecated, please use stdlib::ensure_packages instead.
Configuration should be passed via class/define params instead of as custom facts.
This is to allow shellcheck to match the .sh file extension.
jhoblitt
force-pushed
the
feature/el8-el9
branch
from
25929f7
to
750bf43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.