Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable uniqueId strings to be written to centroid file #63

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

jchiang87
Copy link
Contributor

This change supports using strings that are not cast-able as ints for object ids of instance catalog entries.

@jchiang87 jchiang87 requested a review from cwwalter September 12, 2018 00:41
Copy link
Member

@cwwalter cwwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming uniqueId is now a string this looks fine.

@cwwalter
Copy link
Member

cwwalter commented Sep 12, 2018

I guess formatting might not look good if there are other strings in there with very long SN names now.

@cwwalter
Copy link
Member

Do you know the maximum length of a SN string yet?

@jchiang87
Copy link
Contributor Author

Actually, I think the SNe ids will be rather short, e.g., 'MS_587_6'...one of the advantages of allowing non-numeric characters.

@cwwalter
Copy link
Member

Will it be added to the end of the uniqueId?

Currently the output looks like this:

SourceID                   Flux       xPix       yPix
470331623428        23781.15037    3824.62    3957.35
1605819826180        2504.62232    3984.03    3737.81
1704279223300        2190.84309    3996.09    3666.65

I was thinking if we knew the length we could up the 1st field width.

@jchiang87
Copy link
Contributor Author

@danielsf can say more definitively, but from the implementation, I inferred that strings like MS_587_6 will be the entire uniqueId.

@danielsf
Copy link
Contributor

Jim is correct. As implemented now, the entire SN uniqueId is something like [survey name]_[healpix id]_[number within healpix]

@danielsf
Copy link
Contributor

(MS == "main survey")

@cwwalter
Copy link
Member

So, no way to tell about the connection to the host galaxy?

@jchiang87
Copy link
Contributor Author

That info is in the SN db that the instance catalog generation code reads.

@cwwalter
Copy link
Member

That info is in the SN db that the instance catalog generation code reads.

Right, I was just wondering if that should be encoded in the uniqueID so you wouldn't need to go back and look at the DB to figure that out. But, if it isn't a important use case for users then it doesn't matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants