Update SITCOMTN-092 with notebooks containing analysis for BLOCK-T227 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
dsanmartim
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Hi Bruno.
I just reviewed it and everything looks good (except for all the struggling to get the slews data). It is good to see that the forces measured are far (halfway) from reaching operational limits. Hopefully, they keep like this when increasing TMA motion settings.
I have approved it, but I could not understand exactly if you need to run the analysis from the other notebooks to this data too, or not.
|
The idea of merging this PR is that we can work with short interactions and that I can add a tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.