DM-42660: Use Butler repository list from environment var #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhirving
force-pushed
the
tickets/DM-42660
branch
2 times, most recently
from
716e98e to
23b44dc
Compare
Instead of always requiring a file to exist containing the list of Butler repositories, optionally read it from an environment variable.
It seems to be possible for a datalinker container to get in a state where it is trying to start up, but fails because it is trying to download TAP metadata for a second time and unzip interactively prompts to overwrite. Add the allow-overwrite flag so it can get past this state.
dhirving
force-pushed
the
tickets/DM-42660
branch
from
23b44dc to
378744c
Compare
rra
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always requiring a file to exist containing the list of Butler repositories, optionally read it from an environment variable. Equivalent functionality will be added to daf_butler itself shortly, but I don't want to wait another week to get this deployed.
Also fixed a small bug where
unzipwould interactively prompt to overwrite files if the service crashes on startup, preventing you from seeing the error message from the crash in the logs.