Skip to content

Commit

Permalink
Merge pull request #4 from lsst-sqre/tickets/DM-44204
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathansick authored May 3, 2024
2 parents c7a07a8 + ef965da commit 9595d76
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
5 changes: 5 additions & 0 deletions changelog.d/20240503_102318_athornton_DM_44204.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
<!-- Delete the sections that don't apply -->

### Other changes

Minor improvements to handler docs.
2 changes: 1 addition & 1 deletion src/fastapibootcamp/handlers/astroplan/endpoints.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ async def get_observer(

@astroplan_router.get(
"/observers",
summary="Get all observering sites.",
summary="Get all observing sites.",
response_model=list[ObserverModel],
)
async def get_observers(
Expand Down
8 changes: 4 additions & 4 deletions src/fastapibootcamp/handlers/external.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ class GreetingResponseModel(BaseModel):

@external_router.get(
"/en-greeting",
summary="Get a greeting in engish.",
summary="Get a greeting in English.",
response_model=GreetingResponseModel,
)
async def get_english_greeting(
Expand All @@ -156,7 +156,7 @@ async def get_english_greeting(

@external_router.get(
"/greeting",
summary="Get a greeting in several languages.",
summary="Get a greeting in several languages by using a query parameter.",
response_model=GreetingResponseModel,
)
async def get_multilingual_greeting(
Expand Down Expand Up @@ -200,7 +200,7 @@ async def get_multilingual_greeting(

@external_router.get(
"/greeting/{language}",
summary="Get a greeting in several languages.",
summary="Get a greeting in several languages by using a path parameter.",
response_model=GreetingResponseModel,
)
async def get_multilingual_greeting_path(
Expand Down Expand Up @@ -252,7 +252,7 @@ class GreetingRequestModel(BaseModel):

@external_router.post(
"/greeting",
summary="Get a greeting in several languages.",
summary="Get a greeting in several languages using an HTTP POST.",
response_model=GreetingResponseModel,
)
async def post_greeting(
Expand Down

0 comments on commit 9595d76

Please sign in to comment.