[DM-22959] Allow configuration of who can fiddle log setting #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this group here, and no authorizer, this means no one can alter the log settings. This needs to be moved over to a better way of controlling this via secrets, but this is the first step.
If it doesn't exist, it should just print out a warning but be fine. This should come from a secret, and /etc/creds is a path that is generated from the vault-secret.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, get rid of that group thing. We don't have that group.
Then, set up the new PropertyReaders.dir to point to /etc/creds, where the secrets are placed. If the file doesn't exist, that's fine. Then point it at the file in the directory in web.xml (PropertyReader will look in the directory set in the system property).