DM-38425: Adopt current Safir conventions #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rra
commented
May 10, 2023
rra
commented
- Enable blacken-docs and pydocstyle
- Allow configuration of the path prefix using the standard Safir environment variable
- Enable Slack reporting of uncaught exceptions from the route handlers
- Use the Safir ClientRequestError framework
- Fix the Makefile run target
Enable blacken-docs and pydocstyle linters, as well as the trailing whitespace linter. Fix the docstrings to match pydocstyle's expectations.
Follow our current standard for Safir apps and allow configuration of the prefix for all routes.
Turn on the standard Safir machinery for reporting uncaught route handler exceptions to Slack.
The Makefile run target was still using the aiohttp command. Use tox run -e run instead.
Rather than using separate exception handlers for the exceptions for unknown flocks and unknown monkeys, define those exceptions using the Safir ClientRequestError framework and use the generic exception handler from Safir. Rename those exceptions to end in Error instead of Exception, following our normal naming conventions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.