Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38425: Split out Gafaelfawr storage layer and use models #246

Merged
merged 1 commit into from
May 11, 2023

Conversation

rra
Copy link
Member

@rra rra commented May 10, 2023

Rather than embedding the Gafaelfawr client in the AuthenticatedUser model, separate out a Gafaelfawr storage client. Use copies of the Gafaelfawr models rather than sending and receiving raw JSON. These can be replaced with the real Gafaelfawr models once those are available from PyPI.

Take advantage of this to use Pydantic for the parsing and capture Gafaelfawr parsing errors in a Slack-reportable exception.

@rra rra force-pushed the tickets/DM-38425 branch 4 times, most recently from 98206fd to f177045 Compare May 11, 2023 17:45
Rather than embedding the Gafaelfawr client in the AuthenticatedUser
model, separate out a Gafaelfawr storage client. Use copies of the
Gafaelfawr models rather than sending and receiving raw JSON. These
can be replaced with the real Gafaelfawr models once those are
available from PyPI.

Take advantage of this to use Pydantic for the parsing and capture
Gafaelfawr parsing errors in a Slack-reportable exception.
@rra rra force-pushed the tickets/DM-38425 branch from f177045 to 51cc141 Compare May 11, 2023 19:17
@rra rra merged commit e030268 into main May 11, 2023
@rra rra deleted the tickets/DM-38425 branch May 11, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant