-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-44461: Refresh notebooks #349
Conversation
1264a90
to
92e6607
Compare
0830cfa
to
cd47fee
Compare
Typing error:
Usually before pushing a commit I like to do |
cd47fee
to
d56f90c
Compare
94ad359
to
217ff73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks great! I like how the refreshing works.
f055dbc
to
073e96b
Compare
073e96b
to
fc010b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a scriv file for the change log and I noticed a couple of very minor nits, but otherwise looks great!
fc010b6
to
3f3a206
Compare
refreshing
attribute to Businesses, with an endpoint and a MonkeyFlocker command to set it. Businesses can handle it however they want.NotebookRunner
businesses handle this by recloning their notebook repo and forcing a new session.refreshing
attribute onNotebookRunner
businesses forpush
events from matching repos.I originally wanted to handle this by stopping and starting the flock via the flock manager, but I kept running into conflicts between multiple restart requests, and conflicts between restart requests and the business-as-usual starting and stopping of Jupyter labs and sessions during normal NotebookRunner flock executions. I couldn't work through all of these in the time that I gave myself, so I ditched that plan in favor of what you see here.