DM-43393: Cast job_try to str when making SlackTextField #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arq job_try is an int, and Pydantic will not cast this automatically to a string type.
- update checkout to v4 - update python to v5 - update pre-commit to 3.0.1
jonathansick
added a commit
to lsst-sqre/phalanx
that referenced
this pull request
Mar 20, 2024
Rather than create a synthetic XSRF token, we actually look at the token returned by the Hub and Lab login endpoints and use those. See lsst-sqre/mobu#340
jonathansick
force-pushed
the
tickets/DM-43393
branch
from
82a443a
to
0ad583f
Compare
jonathansick
added a commit
to lsst-sqre/phalanx
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pydantic does not cast the int type of the arq job_try to a string, so we need to do it.
Also extract and use the real XSRF tokens when communicating with JupyterHub and JupyterLab. See lsst-sqre/mobu#340