DM-41188: Rework state management for file servers #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athornton
reviewed
Nov 1, 2023
athornton
reviewed
Nov 1, 2023
athornton
approved these changes
Nov 1, 2023
Use the same pattern as the new state management in LabManager: a dictionary of state objects per user, where the user is never removed once we've seen them. In this case, the state object only needs to hold a lock, not a full-blown manager class. Rather than spawning a separate background task (and Kubernetes watch) for every running file server, use a single background task that watches for all pod changes in the namespace. Use that to catch pod phase changes. Add a background reconcile task to look for any other problems (such as Kubernetes object deletion) and clean up after those. Add Slack reporting of errors in file server operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same pattern as the new state management in LabManager: a dictionary of state objects per user, where the user is never removed once we've seen them. In this case, the state object only needs to hold a lock, not a full-blown manager class.
Rather than spawning a separate background task (and Kubernetes watch) for every running file server, use a single background task that watches for all pod changes in the namespace. Use that to catch pod phase changes. Add a background reconcile task to look for any other problems (such as Kubernetes object deletion) and clean up after those.
Add Slack reporting of errors in file server operations.