DM-41528: Add Python 3.10 tests for Hub plugins #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rra
force-pushed
the
tickets/DM-41528
branch
2 times, most recently
from
3c94900 to
9a9bfd7
Compare
The JupyterHub image currently still uses Python 3.10, so we need to test the authenticator and spawner modules with Python 3.10, but the controller requires at least Python 3.11. Add a separate CI run to test just the authenticator and spawner with a matrix of Python versions that are supported by the Hub but not the controller. Add a new nox environment that tests the authenticator and spawner with the frozen dependencies for JupyterHub. Exclude the Ruff rule to change timezone.utc to UTC for the spawner, since this was added in Python 3.11, and change the code back to timezone.utc.
When testing the authenticator and controller against pinned dependencies, don't let them install any dependencies at all and also pin dev dependencies. This makes the tests somewhat more accurate. Update Python dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JupyterHub image currently still uses Python 3.10, so we need to test the authenticator and spawner modules with Python 3.10, but the controller requires at least Python 3.11. Add a separate CI run to test just the authenticator and spawner with a matrix of Python versions that are supported by the Hub but not the controller, and add some logic to nox to not try to install the controller dependencies if only the authenticator and spawner are being tested.