Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48124: Update dependencies and build system #435

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

rra
Copy link
Member

@rra rra commented Dec 12, 2024

Convert all of the Docker builds to use uv to install packages, which allows removing the update-deps-no-hashes nox session and all of its supporting code. uv understands how to verify hashes if present and skip the verification if the hashes aren't present.

Encode the startup command of the controller directly in the Dockerfile and remove the one-line shell script that was previously used to start it.

Update to the latest Ruff and shared Ruff configuration file. Move Nublado-specific overrides out of the shared Ruff configuration file into pyproject.toml where project-specific overrides should live. Fix a few issues uncovered by Ruff that can be fixed instead of suppressed.

Remove dead configuration from client/pyproject.toml and add some additional metadata. Remove unnecessary dependencies.

Remove the now-unused Dockerfile.sciplat-lab. That build was moved to a different repository.

Update pre-commit and Python dependencies.

@rra rra force-pushed the tickets/DM-48124 branch from ea87c79 to e61a6e4 Compare December 12, 2024 23:17
@rra rra requested a review from athornton December 12, 2024 23:22
Copy link
Member

@athornton athornton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Convert all of the Docker builds to use uv to install packages,
which allows removing the update-deps-no-hashes nox session and
all of its supporting code. uv understands how to verify hashes
if present and skip the verification if the hashes aren't present.

Encode the startup command of the controller directly in the
Dockerfile and remove the one-line shell script that was previously
used to start it.

Update to the latest Ruff and shared Ruff configuration file. Move
Nublado-specific overrides out of the shared Ruff configuration
file into `pyproject.toml` where project-specific overrides should
live. Fix a few issues uncovered by Ruff that can be fixed instead
of suppressed.

Remove dead configuration from `client/pyproject.toml` and add some
additional metadata. Remove unnecessary dependencies.

Remove the now-unused `Dockerfile.sciplat-lab`. That build was moved
to a different repository.

Update pre-commit and Python dependencies.
@rra rra force-pushed the tickets/DM-48124 branch from e61a6e4 to 32ae73e Compare December 12, 2024 23:43
@rra rra merged commit 109f760 into main Dec 12, 2024
8 checks passed
@rra rra deleted the tickets/DM-48124 branch December 12, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants