DM-38279: Return 201 from lab create route #48
Merged
+11
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL to which we redirected the lab creation response is protected by different authentication rules and would require a different token. This probably indicates a deeper problem that we should rethink, but since the REST spawner doesn't want to follow the redirect anyway, return 201 with an empty body and a Location header instead.
rra
added a commit
that referenced
this pull request
Nov 3, 2023
…ns/checkout-4 Bump actions/checkout from 3 to 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL to which we redirected the lab creation response is protected by different authentication rules and would require a different token. This probably indicates a deeper problem that we should rethink, but since the REST spawner doesn't want to follow the redirect anyway, return 201 with an empty body and a Location header instead.