DM-38279: Wait for first image service run during startup #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to start answering user requests until we've populated our list of available images, since otherwise the spawner form may be bogus. Implement this by not returning from start until the first update pass is complete. Don't start background services by default when using a test factory and update the tests that use it to start the background services themselves.
athornton
approved these changes
Mar 30, 2023
rra
pushed a commit
that referenced
this pull request
Nov 3, 2023
tickets/DM-41198: add postgresql-client to image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't want to start answering user requests until we've populated our list of available images, since otherwise the spawner form may be bogus. Implement this by not returning from start until the first update pass is complete.
Don't start background services by default when using a test factory and update the tests that use it to start the background services themselves.