Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-38279: Also check the created namespace #59

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

rra
Copy link
Member

@rra rra commented Mar 31, 2023

Modify the Kubernetes mock to add the created namespace to its objects so that we can check it has the right annotations.

@rra rra requested a review from athornton March 31, 2023 22:25
Copy link
Member

@athornton athornton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not a fan of explicit version/kind specification, but sure.

Modify the Kubernetes mock to add the created namespace to its
objects so that we can check it has the right annotations.
@rra rra force-pushed the tickets/DM-38279a branch from 105139b to e4a736f Compare April 3, 2023 16:39
@rra
Copy link
Member Author

rra commented Apr 3, 2023

PR to fix the kind and api_version stuff should be up today.

@rra rra enabled auto-merge April 3, 2023 16:39
@rra rra merged commit c5f0eee into main Apr 3, 2023
@rra rra deleted the tickets/DM-38279a branch April 3, 2023 16:41
rra added a commit that referenced this pull request Nov 3, 2023
DM-41350: Update Python dependencies, use pytest-sugar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants