[DM-28120] Add support for Gafaelfawr 2.0 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're using this code as a mixin into JupyterHub via its configuration hooks, not as a standalone service, so remove all the web service bits that we're not using. When we've needed a web service, we've written that as a separate package (cachemachine, moneypenny, etc.).
Support a Gafaelfawr token mounted inside the pod and use that by preference if it exists as the admin token for calls to moneypenny rather than creating a JWT. Use the existence of that token as a trigger to use the new token API for getting user information for a user. This is a hack, but it's a temporary hack since we'll be deleting the old code once Gafaelfawr 2.0 is deployed everywhere.
cbanek
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last is a hack, but it's a temporary hack because the old code will go away once Gafaelfawr 2.0 is deployed everywhere.