This repository has been archived by the owner on Jan 4, 2024. It is now read-only.
DM-41350: Handle terminating and terminated status #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athornton
reviewed
Oct 26, 2023
| @@ -42,9 +42,10 @@ class LabStatus(str, Enum): | |||
| of the lab controller. | |||
| """ | |||
|
|
|||
| STARTING = "starting" | |||
| PENDING = "pending" | |||
| RUNNING = "running" | |||
There was a problem hiding this comment.
This would all be so much nicer if k8s did this cleanly rather than Pending/Running/Succeeded/Failed/Unknown and then also having to parse the Reason field to figure out how it got there.
athornton
approved these changes
Oct 26, 2023
There was a problem hiding this comment.
I think this is fine, although maybe a little more commentary that LabStatus doesn't actually exactly track the K8s Pod Status Phase, but represents a conceptual rollup of Phase and Reason.
Or perhaps we should just abandon the abstraction and use the K8s Phases and Reasons more directly? I don't know. I am finding pod and container lifecycle handling very frustrating.
Update the lab status enum to match the current Nublado controller, including renaming starting to pending. Add support for terminated status, which will be used for labs killed by the idle culler. Update comments for the (soon to be implemented) behavior of the Nublado controller. Treat terminating status the same as terminated: tell the hub that the lab has exited, even though it hasn't yet. We want to allow the user to start spawning a new lab, and if they kick that off before the lab deletion completes, we'll join the existing delete call now that the controller supports multiple simultaneous deletes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the lab status enum to match the current Nublado controller, including renaming starting to pending. Add support for terminated status, which will be used for labs killed by the idle culler. Update comments for the (soon to be implemented) behavior of the Nublado controller.
Treat terminating status the same as terminated: tell the hub that the lab has exited, even though it hasn't yet. We want to allow the user to start spawning a new lab, and if they kick that off before the lab deletion completes, we'll join the existing delete call now that the controller supports multiple simultaneous deletes.